Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v9]

2023-10-11 Thread Dmitry Chuyko
> Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile` diagnostic command-line option and the > Compiler.add_dir

RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-11 Thread Johannes Bechberger
Fix `onthrow` issue by passing the event info to the `initialize` method. This prevents `jdb` from receiving a broken exception event and throwing an internal NullPointerException, upon attaching to the JDWP-agent. - Commit messages: - Fix onthrow issue Changes: https://git.openjd

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-11 Thread Christoph Langer
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. LGTM ---

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-11 Thread Chris Plummer
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. Do you ha

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-11 Thread Johannes Bechberger
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. No. But i

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-11 Thread Chris Plummer
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. It would

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-11 Thread Chris Plummer
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. Also, doe

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v27]

2023-10-11 Thread Man Cao
On Thu, 5 Oct 2023 03:00:36 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > add comment and change if defined to ifdef Changes re

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v18]

2023-10-11 Thread Man Cao
On Fri, 15 Sep 2023 01:27:04 GMT, David Holmes wrote: >> Jonathan Joo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clean up test and improve total counter name > > src/hotspot/share/runtime/perfData.hpp line 64: > >> 62: COM_THREAD

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v27]

2023-10-11 Thread Man Cao
On Thu, 5 Oct 2023 03:00:36 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > add comment and change if defined to ifdef test/jdk/s

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order

2023-10-11 Thread Chris Plummer
On Wed, 11 Oct 2023 00:39:23 GMT, Alex Menkov wrote: > All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. > The change adds several fields in one of the test classes to verify order of > the returned fields (as described by GetClassFields spec). > Additionally added "pr

Re: RFR: 8316464: 3 sun/tools tests ignore VM flags [v2]

2023-10-11 Thread Chris Plummer
On Tue, 10 Oct 2023 20:34:44 GMT, Leonid Mesnik wrote: >> I marked tests >> sun/tools/jcmd/TestProcessHelper.java >> sun/tools/jinfo/JInfoTest.java >> as headless. They used different specific VM options and are not worth >> executing with other VM flags. >> And fixed >> sun/tools/jstat/JStat