Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v6]

2023-11-03 Thread Thomas Stuefe
On Wed, 1 Nov 2023 10:04:30 GMT, Johan Sjölen wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix various builds > > OK, went through the cache. Will continue later. @jdksjolen anything more needed from my side?

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v5]

2023-11-03 Thread Ivan Walulya
On Tue, 31 Oct 2023 19:14:13 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there i

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v10]

2023-11-03 Thread Ivan Walulya
On Fri, 3 Nov 2023 13:46:51 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there is

Integrated: JDK-8319053: Segment dump files remain after parallel heap dump on Windows

2023-11-03 Thread Alex Menkov
On Wed, 1 Nov 2023 19:23:14 GMT, Alex Menkov wrote: > Segment file is closed from DumpWriter dtor. > On Unix systems `remove` can delete an opened file, on Windows it fails with > "access denied". > The fix destroys DumpWriter objects for segment files after all data are > dumped This pull req

Re: RFR: 8318631: GetStackTraceSuspendedStressTest.java failed with: check_jvmti_status: JVMTI function returned error: JVMTI_ERROR_THREAD_NOT_ALIVE (15)

2023-11-03 Thread Alex Menkov
On Fri, 3 Nov 2023 04:31:33 GMT, Serguei Spitsyn wrote: > It is a fix of a minor test issue. > The test should not fail when the JVMTI function `SetEventNotificationMode()` > returns errors codes: > - `JVMTI_ERROR_THREAD_NOT_ALIVE` > - `JVMTI_ERROR_WRONG_PHASE` > > Tested the fix locally and wi

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v9]

2023-11-03 Thread Albert Mingkun Yang
On Fri, 3 Nov 2023 13:53:35 GMT, Thomas Schatzl wrote: >> src/hotspot/share/gc/g1/g1YoungCollector.cpp line 87: >> >>> 85: GCCause::to_string(_pause_cause), >>> 86: _collector->evacuation_pinned() ? " (Pinned)" : "", >>> 87: _collector->evacuation_alloc_fai

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v9]

2023-11-03 Thread Thomas Schatzl
On Fri, 3 Nov 2023 12:44:10 GMT, Albert Mingkun Yang wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> ayang review - renamings + documentation > > src/hotspot/share/gc/g1/g1YoungCollector.cpp line 87: > >> 85:

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v10]

2023-11-03 Thread Albert Mingkun Yang
On Fri, 3 Nov 2023 13:46:51 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there is

getProcessCPULoad returns different CPU percentage as comparead to top linux command

2023-11-03 Thread Nikhil Agarwal
Hi All, getProcessCPULoad returns different CPU percentage as compared to top linux command intermittently . Does it supposed to returned same data as top command always . Should the getProcessCPULoad value be same as top/number of cpus always ? regards Nikhil

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v9]

2023-11-03 Thread Thomas Schatzl
On Fri, 3 Nov 2023 12:41:05 GMT, Albert Mingkun Yang wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> ayang review - renamings + documentation > > src/hotspot/share/gc/g1/g1_globals.hpp line 327: > >> 325:

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v10]

2023-11-03 Thread Thomas Schatzl
> The JEP covers the idea very well, so I'm only covering some implementation > details here: > > * regions get a "pin count" (reference count). As long as it is non-zero, we > conservatively never reclaim that region even if there is no reference in > there. JNI code might have references to i

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v9]

2023-11-03 Thread Albert Mingkun Yang
On Fri, 3 Nov 2023 12:32:02 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there is

RFR: 8319376: Parallel: Forwarded objects during heap inspection

2023-11-03 Thread Roman Kennke
See JBS issue for details. Testing: - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC - [ ] tier1 -XX:+UseParallelGC - [ ] tier2 -XX:+UseParallelGC - [ ] hotspot_gc - Commit messages: - 8319376: Parallel: Forwarded objects during heap inspection Changes: h

RFR: 8318631: GetStackTraceSuspendedStressTest.java failed with: check_jvmti_status: JVMTI function returned error: JVMTI_ERROR_THREAD_NOT_ALIVE (15)

2023-11-03 Thread Serguei Spitsyn
It is a fix of a minor test issue. The test should not fail when the JVMTI function `SetEventNotificationMode()` returns errors codes: - `JVMTI_ERROR_THREAD_NOT_ALIVE` - `JVMTI_ERROR_WRONG_PHASE` Tested the fix locally and with mach5 test runs. - Commit messages: - 8318631: GetStac

Integrated: JDK-8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"

2023-11-03 Thread Johannes Bechberger
On Wed, 25 Oct 2023 11:27:18 GMT, Johannes Bechberger wrote: > Fix race condition in debugger port selection, introduced with > [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920). > > Tested on my Mac M1, but it doesn't contain platform-dependent code. This pull request has now been i

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-03 Thread Thomas Schatzl
On Thu, 2 Nov 2023 15:51:35 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there is

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v9]

2023-11-03 Thread Thomas Schatzl
> The JEP covers the idea very well, so I'm only covering some implementation > details here: > > * regions get a "pin count" (reference count). As long as it is non-zero, we > conservatively never reclaim that region even if there is no reference in > there. JNI code might have references to i

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-03 Thread Thomas Schatzl
On Fri, 3 Nov 2023 09:56:43 GMT, Albert Mingkun Yang wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add documentation about why and how we handle pinned regions in the >> young/old generation. > > src/hotspot/s

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-03 Thread Albert Mingkun Yang
On Thu, 2 Nov 2023 15:52:09 GMT, Thomas Schatzl wrote: >> I (still) do not think it is possible after some more re-testing. There are >> the following situations I can think of: >> >> * string deduplication is a need-to-be-supported case where only the C code >> may have a reference to a pinne

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-03 Thread Albert Mingkun Yang
On Thu, 2 Nov 2023 15:51:35 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there is

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-03 Thread Thomas Stuefe
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools ou

Re: RFR: JDK-8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use" [v6]

2023-11-03 Thread Johannes Bechberger
> Fix race condition in debugger port selection, introduced with > [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920). > > Tested on my Mac M1, but it doesn't contain platform-dependent code. Johannes Bechberger has updated the pull request incrementally with one additional commit since