On Tue, 7 Nov 2023 18:12:45 GMT, Roman Kennke wrote:
>> See JBS issue for details.
>>
>> Testing:
>> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
>> - [x] tier1 -XX:+UseParallelGC
>> - [ ] tier2 -XX:+UseParallelGC
>> - [ ] hotspot_gc
>
> Roman Kennke has updated th
> See JBS issue for details.
>
> Testing:
> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
> - [x] tier1 -XX:+UseParallelGC
> - [ ] tier2 -XX:+UseParallelGC
> - [ ] hotspot_gc
Roman Kennke has updated the pull request incrementally with one additional
commit since th
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim that region even if there is no reference in
> there. JNI code might have references to i
On Wed, 1 Nov 2023 10:04:30 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> OK, went through the cache. Will continue later.
> @jdksjolen anything more needed from my side
On Tue, 7 Nov 2023 14:59:48 GMT, Roman Kennke wrote:
>> See JBS issue for details.
>>
>> Testing:
>> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
>> - [x] tier1 -XX:+UseParallelGC
>> - [ ] tier2 -XX:+UseParallelGC
>> - [ ] hotspot_gc
>
> Roman Kennke has updated th
> See JBS issue for details.
>
> Testing:
> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
> - [x] tier1 -XX:+UseParallelGC
> - [ ] tier2 -XX:+UseParallelGC
> - [ ] hotspot_gc
Roman Kennke has updated the pull request incrementally with one additional
commit since th
On Mon, 6 Nov 2023 23:22:03 GMT, Serguei Spitsyn wrote:
>> The handshakes support for virtual threads is needed to simplify the JVMTI
>> implementation for virtual threads. There is a significant duplication in
>> the JVMTI code to differentiate code intended to support platform, virtual
>> th
On Tue, 7 Nov 2023 14:31:49 GMT, Roman Kennke wrote:
>> See JBS issue for details.
>>
>> Testing:
>> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
>> - [x] tier1 -XX:+UseParallelGC
>> - [ ] tier2 -XX:+UseParallelGC
>> - [ ] hotspot_gc
>
> Roman Kennke has updated th
> See JBS issue for details.
>
> Testing:
> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
> - [x] tier1 -XX:+UseParallelGC
> - [ ] tier2 -XX:+UseParallelGC
> - [ ] hotspot_gc
Roman Kennke has updated the pull request incrementally with one additional
commit since th
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim that region even if there is no reference in
> there. JNI code might have references to i
On Tue, 7 Nov 2023 12:38:14 GMT, Roman Kennke wrote:
> all references to original copies of promoted objects are updated, and
> therefore the original copies are dead (and can safely be skipped)
Yes; after scavenging, all pointers are correct (same value for promotion-fail
and new value otherw
On Tue, 7 Nov 2023 10:02:04 GMT, Albert Mingkun Yang wrote:
> > Would the failed-promotion slide directly into full-GC which repairs it?
>
> No, promotion-fail objects are specially handled, as documented in
> `PSPromotionManager::oop_promotion_failed`. Other successfully forwarded
> objects a
> The `find` method now is
> ```C++
> template
> int find(T* token, bool f(T*, E)) const {
> ...
>
> Any other functions which use this are also changed.
> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
> Windows passed.
Afshin Zafari has updated the pull request inc
On Mon, 6 Nov 2023 19:46:07 GMT, Roman Kennke wrote:
> I'm curious (and puzzled), though. How would this situation normally have
> been repaired without this explicit header-resetting code? Would the
> failed-promotion slide directly into full-GC which repairs it? OTOH, I don't
> even see code
On Wed, 1 Nov 2023 17:10:34 GMT, Kevin Walls wrote:
> Discovered while testing changes that made this test fail. The test failure
> is hard to diagnose as it logs and retries at full speed, possibly forever,
> until timeout. This can hit a log file limit. We can save thousands of
> lines of
On Mon, 6 Nov 2023 19:46:07 GMT, Roman Kennke wrote:
> Would the failed-promotion slide directly into full-GC which repairs it?
No, promotion-fail objects are specially handled, as documented in
`PSPromotionManager::oop_promotion_failed`. Other successfully forwarded
objects are essentially de
On Tue, 7 Nov 2023 01:06:12 GMT, Man Cao wrote:
> I think it looks great. It is mainly refactoring that consolidates the
> declarations/definitions of the hsperf counters in to a single file. Would it
> be better to name that class `CPUTimeCounters`, so we could move
> `sun.threads.cpu_time.vm
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim that region even if there is no reference in
> there. JNI code might have references to i
18 matches
Mail list logo
