Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-09 Thread Thomas Stuefe
On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes wrote: >>> > As this adds a JCmd, doesn't this need both a CSR and a manual entry? >>> >>> * CSR: not sure; there are precedences for going with CSR and without >>> CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR >>> n

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v12]

2023-11-09 Thread Thomas Stuefe
> Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out there that attempt to > annotate the process memory map wi

Re: RFR: 8318895: Deoptimization results in incorrect lightweight locking stack [v2]

2023-11-09 Thread Richard Reingruber
On Thu, 9 Nov 2023 15:54:13 GMT, Roman Kennke wrote: >> See JBS issue for details. >> >> I basically: >> - took the test-modification and turned it into its own test-case >> - added test runners for lightweight- and legacy-locking, so that we keep >> testing both, no matter what is the defaul

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-09 Thread Thomas Stuefe
On Thu, 9 Nov 2023 07:27:37 GMT, David Holmes wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another windows error > > src/hotspot/share/services/diagnosticCommand.cpp line 1193: > >> 1191: output()->pri

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v11]

2023-11-09 Thread Thomas Stuefe
> Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out there that attempt to > annotate the process memory map wi

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v10]

2023-11-09 Thread Thomas Stuefe
> Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out there that attempt to > annotate the process memory map wi

Re: RFR: JDK-8319375: test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java runs into OutOfMemoryError: Metaspace on AIX

2023-11-09 Thread David Holmes
On Wed, 8 Nov 2023 08:29:52 GMT, Matthias Baesken wrote: > On AIX the test > test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java > runs into this error: > > java.lang.RuntimeException: java.lang.OutOfMemoryError: Metaspace > at > jdk.compiler/com.sun.tools.javac

Re: RFR: JDK-8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case

2023-11-09 Thread Matthias Baesken
On Wed, 8 Nov 2023 21:55:44 GMT, Alex Menkov wrote: > does getaddrinfo return a single address? (parseAllowedAddr assumes so, but > maybe that's wrong in the case) >From what I see on AIX, only one entry is returned in the results struct of >the getaddrinfo call. - PR Comment: h

Re: RFR: JDK-8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case

2023-11-09 Thread Matthias Baesken
On Wed, 8 Nov 2023 17:57:42 GMT, Chris Plummer wrote: > The downside of this change is that it will cause the option parsing code to > not properly produce an error if an IPv4 mask prefix between 32 and 128 is > given. Yes this is true; maybe we should not unconditionally increase the maxValu

Re: RFR: 8318895: Deoptimization results in incorrect lightweight locking stack [v2]

2023-11-09 Thread Roman Kennke
> See JBS issue for details. > > I basically: > - took the test-modification and turned it into its own test-case > - added test runners for lightweight- and legacy-locking, so that we keep > testing both, no matter what is the default > - added Axels fix (mentioned in the JBS issue) with the

Re: RFR: 8318895: Deoptimization results in incorrect lightweight locking stack

2023-11-09 Thread Richard Reingruber
On Wed, 8 Nov 2023 19:00:53 GMT, Roman Kennke wrote: > See JBS issue for details. > > I basically: > - took the test-modification and turned it into its own test-case > - added test runners for lightweight- and legacy-locking, so that we keep > testing both, no matter what is the default > -

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v40]

2023-11-09 Thread Stefan Johansson
On Thu, 9 Nov 2023 05:27:40 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing cpuTimeCounters files One more thing I no

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v40]

2023-11-09 Thread Stefan Johansson
On Thu, 9 Nov 2023 05:27:40 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing cpuTimeCounters files src/hotspot/share/g

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v40]

2023-11-09 Thread Stefan Johansson
On Thu, 9 Nov 2023 05:27:40 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing cpuTimeCounters files A few more comments

Re: RFR: 8318706: Implement JEP 423: Region Pinning for G1 [v9]

2023-11-09 Thread Thomas Schatzl
On Wed, 8 Nov 2023 14:46:16 GMT, Stefan Johansson wrote: >> The example looks good to me. > > Have the final output looking something like this was agreed on during > internal discussion: > GC(6) Pause Young (Normal) (Evacuation Failure: Pinned) 1M->1M(22M) 36.16ms > GC(6) Pause Young (Normal) (

Re: RFR: 8318706: Implement JEP 423: Region Pinning for G1 [v16]

2023-11-09 Thread Thomas Schatzl
> The JEP covers the idea very well, so I'm only covering some implementation > details here: > > * regions get a "pin count" (reference count). As long as it is non-zero, we > conservatively never reclaim that region even if there is no reference in > there. JNI code might have references to i

Re: RFR: JDK-8319375: test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java runs into OutOfMemoryError: Metaspace on AIX

2023-11-09 Thread Matthias Baesken
On Thu, 9 Nov 2023 07:58:29 GMT, David Holmes wrote: > > LGTM. Thanks for verifying we are not hiding a leak with the increase. > > Has that actually been verified? I couldn't quite understand what was being > said in the description. This new value would need to be tested on all > platforms,

Re: RFR: JDK-8319375: test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java runs into OutOfMemoryError: Metaspace on AIX

2023-11-09 Thread David Holmes
On Wed, 8 Nov 2023 16:12:48 GMT, Lutz Schmidt wrote: > LGTM. Thanks for verifying we are not hiding a leak with the increase. Has that actually been verified? I couldn't quite understand what was being said in the description. This new value would need to be tested on all platforms, on an unpa