Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-07 Thread Sam James
On Tue, 6 Feb 2024 16:10:38 GMT, Magnus Ihse Bursie wrote: >> make/modules/jdk.hotspot.agent/Lib.gmk line 31: >> >>> 29: >>> 30: ifeq ($(call isTargetOs, linux), true) >>> 31: SA_CFLAGS := -D_FILE_OFFSET_BITS=64 >> >> We have two choices to feel a bit more comfortable: >> 1) We

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v7]

2024-02-07 Thread Magnus Ihse Bursie
On Tue, 6 Feb 2024 08:05:14 GMT, Matthias Baesken wrote: >>> I hope finally the AIX part of this PR is done. >> >> Thanks for the AIX related effort ; I put it again into our internal >> build/test queue. > >> >> Thanks for the AIX related effort ; I put it again into our internal >>

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-07 Thread Sam James
On Thu, 8 Feb 2024 07:41:02 GMT, Magnus Ihse Bursie wrote: >> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we >> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK >> native libraries. > > Magnus Ihse Bursie has updated the pull request

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-07 Thread Magnus Ihse Bursie
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we > should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK > native libraries. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v3]

2024-02-07 Thread David Holmes
On Wed, 7 Feb 2024 07:02:11 GMT, Serguei Spitsyn wrote: >> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the >> spec. >> The function returns the following structure: >> >> >> typedef struct { >> jthread owner; >> jint entry_count; >> jint waiter_count;

RFR: 8325464: GCCause.java out of sync with gcCause.hpp

2024-02-07 Thread Yifeng Jin
This patch updates `GCCause.java` to keep sync with latest `gcCause.hpp`. - Commit messages: - GCCause.java out of sync with gcCause.hpp Changes: https://git.openjdk.org/jdk/pull/17766/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17766=00 Issue:

RFR: 8316460: 4 javax/management tests ignore VM flags

2024-02-07 Thread Leonid Mesnik
The tests javax/management/ImplementationVersion/ImplVersionTest.java javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java javax/management/remote/mandatory/version/ImplVersionTest.java javax/management/security/HashedPasswordFileTest.java were updated to use

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v7]

2024-02-07 Thread Sam James
On Fri, 2 Feb 2024 15:49:59 GMT, Magnus Ihse Bursie wrote: >> I wrote earlier: >> >>> There is one change that merit highlighting: In >>> src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c, I kept the >>> dlsym lookup for openat64, fstatat64 and fdopendir64, on non-BSD OSes (i.e. >>>

Re: RFR: 8325367: Rename nsk_list.h

2024-02-07 Thread Kim Barrett
On Wed, 7 Feb 2024 22:01:13 GMT, Coleen Phillimore wrote: >> Please review this trivial change that renames the file >> test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_list.h to nsk_list.hpp. >> >> Testing: mach5 tier1 >> Note that build would fail if #include updates were incorrect or

Integrated: 8325367: Rename nsk_list.h

2024-02-07 Thread Kim Barrett
On Wed, 7 Feb 2024 20:48:18 GMT, Kim Barrett wrote: > Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_list.h to nsk_list.hpp. > > Testing: mach5 tier1 > Note that build would fail if #include updates were incorrect or incomplete.

Re: RFR: 8323681: SA PointerFinder code should support G1 [v3]

2024-02-07 Thread Chris Plummer
On Tue, 6 Feb 2024 19:24:04 GMT, Chris Plummer wrote: >> This PR adds G1 support to PointerFinder/PointerLocation. Previously we only >> had SerialGC support. Previously for G1 addresses SA would only report that >> the address is "In unknown section of Java heap" with no other details. Now

Integrated: 8323681: SA PointerFinder code should support G1

2024-02-07 Thread Chris Plummer
On Fri, 2 Feb 2024 23:24:20 GMT, Chris Plummer wrote: > This PR adds G1 support to PointerFinder/PointerLocation. Previously we only > had SerialGC support. Previously for G1 addresses SA would only report that > the address is "In unknown section of Java heap" with no other details. Now > it

Re: RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v3]

2024-02-07 Thread Daniel D . Daugherty
On Wed, 7 Feb 2024 07:02:11 GMT, Serguei Spitsyn wrote: >> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the >> spec. >> The function returns the following structure: >> >> >> typedef struct { >> jthread owner; >> jint entry_count; >> jint waiter_count;

Re: RFR: 8325367: Rename nsk_list.h

2024-02-07 Thread Coleen Phillimore
On Wed, 7 Feb 2024 20:48:18 GMT, Kim Barrett wrote: > Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_list.h to nsk_list.hpp. > > Testing: mach5 tier1 > Note that build would fail if #include updates were incorrect or incomplete.

RFR: JDK-8311076: RedefineClasses doesn't check for ConstantPool overflow

2024-02-07 Thread Alex Menkov
The fix adds check that merged constant pool does not overflow u2 (two-byte unsigned). The check is added after merging `the_class` and `scratch_class` constant pools, but before rewriting constant pool references. testing: - sanity tier1; - all RedefineClasses/RetransformClasses tests: -

RFR: 8325367: Rename nsk_list.h

2024-02-07 Thread Kim Barrett
Please review this trivial change that renames the file test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_list.h to nsk_list.hpp. Testing: mach5 tier1 Note that build would fail if #include updates were incorrect or incomplete. - Commit messages: - rename nsk_list.h Changes:

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v9]

2024-02-07 Thread Joachim Kern
On Tue, 6 Feb 2024 08:18:14 GMT, Magnus Ihse Bursie wrote: >> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we >> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK >> native libraries. > > Magnus Ihse Bursie has updated the pull request

Integrated: 8325109: Sort method modifiers in canonical order

2024-02-07 Thread Magnus Ihse Bursie
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-07 Thread Magnus Ihse Bursie
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial