Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v10]

2024-04-05 Thread Alex Menkov
On Wed, 27 Mar 2024 13:44:42 GMT, Matthias Baesken wrote: >> Currently jcmd command GC.heap_dump only works with an additionally provided >> file name. >> Syntax : GC.heap_dump [options] >> >> In case the JVM has the XX - flag HeapDumpPath set, we should support an >> additional mode where

Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v10]

2024-04-05 Thread Christoph Langer
On Fri, 5 Apr 2024 12:49:53 GMT, Sandra Payne wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> adjust java.1 man page > > Yes, exactly the latter. With this change, it opens the door for the above > scenario

RFR: 8329774 Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html

2024-04-05 Thread Ludvig Janiuk
I used "fold -sw 120" and removed trailing whitespaces. - Commit messages: - 8329774 Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html Changes: https://git.openjdk.org/jdk/pull/18654/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18654=00 Issue:

Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v10]

2024-04-05 Thread Sandra Payne
On Wed, 27 Mar 2024 13:44:42 GMT, Matthias Baesken wrote: >> Currently jcmd command GC.heap_dump only works with an additionally provided >> file name. >> Syntax : GC.heap_dump [options] >> >> In case the JVM has the XX - flag HeapDumpPath set, we should support an >> additional mode where

RFR: 8329629: GC interfaces should work directly against nmethod instead of CodeBlob

2024-04-05 Thread Stefan Karlsson
The GCs scan and handles nmethods and ignores CodeBlobs of other kinds. The I propose that we stop sending in CodeBlobs to the GCs and make sure to only give them nmethods. I removed `void CodeCache::blobs_do(CodeBlobClosure* f)` since there's no more usage of that function. Is this OK? I

Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v10]

2024-04-05 Thread Matthias Baesken
On Fri, 5 Apr 2024 08:57:09 GMT, Sandra Payne wrote: > Many customers may see such a change as a regression, as they rely on > separation of location for heap dumps generated by the > JVM at OOME and heap > dumps manually pulled by various other processes attaching to the JVM. With this

Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v10]

2024-04-05 Thread Sandra Payne
On Wed, 27 Mar 2024 13:44:42 GMT, Matthias Baesken wrote: >> Currently jcmd command GC.heap_dump only works with an additionally provided >> file name. >> Syntax : GC.heap_dump [options] >> >> In case the JVM has the XX - flag HeapDumpPath set, we should support an >> additional mode where

Integrated: 8329655: Cleanup KlassObj and klassOop names after the PermGen removal

2024-04-05 Thread Stefan Karlsson
On Thu, 4 Apr 2024 09:45:58 GMT, Stefan Karlsson wrote: > We have a few places that uses the terms `KlassObj` and `klassOop` when > referring to Klasses. This is old code from before the PermGen removal, when > Klasses also were Java objects. > > These names tripped me up when I was reading

Re: RFR: 8329655: Cleanup KlassObj and klassOop names after the PermGen removal [v2]

2024-04-05 Thread Stefan Karlsson
On Thu, 4 Apr 2024 12:18:24 GMT, Stefan Karlsson wrote: >> We have a few places that uses the terms `KlassObj` and `klassOop` when >> referring to Klasses. This is old code from before the PermGen removal, when >> Klasses also were Java objects. >> >> These names tripped me up when I was