Re: RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on macos-aarch64 [v2]

2024-05-07 Thread SendaoYan
On Tue, 7 May 2024 17:43:02 GMT, Chris Plummer wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all > > test/hotspot/jtreg/ProblemList.txt line

Re: RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on macos-aarch64 [v2]

2024-05-07 Thread SendaoYan
> Hi, > GHA > [runner](https://github.com/sendaoYan/jdk-ysd/actions/runs/8881868940/job/24386063136) > shows that serviceability/dcmd/gc/RunFinalizationTest.java intermittent fail > on macos-aarch64. The testcase has been problemlisted on > linux-all,windows-x64,aix-ppc64. I think we should

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Jonathan Gibbons
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. Marked as reviewed by jjg (Reviewer). - PR Review:

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Pavel Rappo
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. Thanks for reviewing it Joe, I'm now delegating integration of this PR to @JesperIRL, you, or anyone who

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v2]

2024-05-07 Thread Chris Plummer
On Tue, 7 May 2024 16:38:23 GMT, Matias Saavedra Silva wrote: >> The beginning of the RW region contains pointers to c++ vtables which are >> always located at a fixed offset from the shared base address at runtime. >> This offset can be calculated at dumptime and stored with the read-only

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Joe Darcy
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. Marked as reviewed by darcy (Reviewer). > This PR is standalone as opposed to dependent because the #18787

Re: RFR: 8328866: Add raw monitor rank support to the debug agent. [v4]

2024-05-07 Thread Chris Plummer
On Tue, 7 May 2024 18:53:23 GMT, Chris Plummer wrote: >> This PR adds ranked monitor support to the debug agent. The debug agent has >> a large number of monitors, and it's really hard to know which order to grab >> them in, and for that matter which monitors might already be held at any >>

Re: RFR: 8328866: Add raw monitor rank support to the debug agent. [v4]

2024-05-07 Thread Chris Plummer
> This PR adds ranked monitor support to the debug agent. The debug agent has a > large number of monitors, and it's really hard to know which order to grab > them in, and for that matter which monitors might already be held at any > given moment. By imposing a rank on each monitor, we can

Re: RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on macos-aarch64

2024-05-07 Thread Chris Plummer
On Wed, 1 May 2024 14:14:22 GMT, SendaoYan wrote: > Hi, > GHA > [runner](https://github.com/sendaoYan/jdk-ysd/actions/runs/8881868940/job/24386063136) > shows that serviceability/dcmd/gc/RunFinalizationTest.java intermittent fail > on macos-aarch64. The testcase has been problemlisted on >

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v2]

2024-05-07 Thread Matias Saavedra Silva
> The beginning of the RW region contains pointers to c++ vtables which are > always located at a fixed offset from the shared base address at runtime. > This offset can be calculated at dumptime and stored with the read-only > tables at the top of the RO region. As a further improvement, all

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v2]

2024-05-07 Thread Laurence Cable
just a thought ... what if the code were to recurse "up" the process tree if the target JVM had elevated privs (and its /proc/... was not accessible), in order to find an ancestor whose /proc was accessible, since the JVM itself does not modify its pid or mnt namespaces (or capabilities) only

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap

2024-05-07 Thread Matias Saavedra Silva
On Mon, 6 May 2024 22:32:12 GMT, Chris Plummer wrote: >> The beginning of the RW region contains pointers to c++ vtables which are >> always located at a fixed offset from the shared base address at runtime. >> This offset can be calculated at dumptime and stored with the read-only >> tables

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Pavel Rappo
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. This PR is standalone as opposed to dependent because the https://github.com/openjdk/jdk/pull/18787

RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Pavel Rappo
Please review this mechanical change to man pages. This PR should be integrated after https://github.com/openjdk/jdk/pull/18787. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jdk/pull/19119/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19119=00