Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v3]

2024-06-27 Thread Thomas Stuefe
On Thu, 27 Jun 2024 18:38:14 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help`

Integrated: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

2024-06-27 Thread Chris Plummer
On Wed, 26 Jun 2024 17:26:52 GMT, Chris Plummer wrote: > Allow ObjectCollectedException during ThreadReference.toString() call. This > can happen when using SUSPEND_NONE since the thread continues to run after > hitting the breakpoint. > > So far I've just run the test locally. I'll run the

Re: RFR: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

2024-06-27 Thread Chris Plummer
On Wed, 26 Jun 2024 17:26:52 GMT, Chris Plummer wrote: > Allow ObjectCollectedException during ThreadReference.toString() call. This > can happen when using SUSPEND_NONE since the thread continues to run after > hitting the breakpoint. > > So far I've just run the test locally. I'll run the

Re: RFR: 8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed with CPU time out of expected range

2024-06-27 Thread Kevin Walls
On Thu, 27 Jun 2024 08:54:16 GMT, Kevin Walls wrote: > This test has had occasional failures for years, possibly forever. > A previous update made the test "othervm" which removed some interruptions, > but a time accounting problem remains. > > This change adds a simple sleep after observing

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v7]

2024-06-27 Thread Larry Cable
On Tue, 25 Jun 2024 13:54:46 GMT, Severin Gehwolf wrote: >> Please review this enhancement to the container detection code which allows >> it to figure out whether the JVM is actually running inside a container >> (`podman`, `docker`, `crio`), or with some other means that enforces >>

Re: RFR: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

2024-06-27 Thread Coleen Phillimore
On Wed, 26 Jun 2024 17:26:52 GMT, Chris Plummer wrote: > Allow ObjectCollectedException during ThreadReference.toString() call. This > can happen when using SUSPEND_NONE since the thread continues to run after > hitting the breakpoint. > > So far I've just run the test locally. I'll run the

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v7]

2024-06-27 Thread Larry Cable
On Tue, 25 Jun 2024 13:54:46 GMT, Severin Gehwolf wrote: >> Please review this enhancement to the container detection code which allows >> it to figure out whether the JVM is actually running inside a container >> (`podman`, `docker`, `crio`), or with some other means that enforces >>

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v3]

2024-06-27 Thread Sonia Zaldana Calles
> Hi all, > > This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) > enabling jcmd to accept "help" as an argument to subcommands. > > Testing: > - [x] Verified running `jcmd 4711 VM.metaspace help` works along with other > subcommands. > - [x] Added test case passes.

Re: RFR: 8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed with CPU time out of expected range

2024-06-27 Thread Paul Hohensee
On Thu, 27 Jun 2024 08:54:16 GMT, Kevin Walls wrote: > This test has had occasional failures for years, possibly forever. > A previous update made the test "othervm" which removed some interruptions, > but a time accounting problem remains. > > This change adds a simple sleep after observing

RFR: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException

2024-06-27 Thread Kevin Walls
Disable running this test with -Xcomp. The NPE seen in this test is due to a timeout establishing the connection. ServerCommunicatorAdmin hits its timeout, during an addNotificationListener call on a new connection. -Xcomp causes this slowdown and the failure is reproducible. There is no

Re: [jdk23] RFR: 8326820: Metadata artificially kept alive

2024-06-27 Thread Stefan Karlsson
On Thu, 27 Jun 2024 14:30:43 GMT, Axel Boldt-Christmas wrote: > Hi all, > > This pull request contains a backport of commit > [5909d541](https://github.com/openjdk/jdk/commit/5909d54147355dd7da5786ff39ead4c15816705c) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The

[jdk23] RFR: 8326820: Metadata artificially kept alive

2024-06-27 Thread Axel Boldt-Christmas
Hi all, This pull request contains a backport of commit [5909d541](https://github.com/openjdk/jdk/commit/5909d54147355dd7da5786ff39ead4c15816705c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Axel Boldt-Christmas on 27 Jun 2024

Integrated: 8326820: Metadata artificially kept alive

2024-06-27 Thread Axel Boldt-Christmas
On Tue, 18 Jun 2024 12:25:36 GMT, Axel Boldt-Christmas wrote: > ClassLoaderDataGraph provides APIs for walking different metadata. All the > iterators which are not designed to be used by the GC also keep the holder of > the CLDs alive and by extensions keeps all metadata alive. This is >

Re: RFR: 8326820: Metadata artificially kept alive [v5]

2024-06-27 Thread Axel Boldt-Christmas
On Thu, 27 Jun 2024 13:38:22 GMT, Axel Boldt-Christmas wrote: >> ClassLoaderDataGraph provides APIs for walking different metadata. All the >> iterators which are not designed to be used by the GC also keep the holder >> of the CLDs alive and by extensions keeps all metadata alive. This is

Re: RFR: 8326820: Metadata artificially kept alive [v5]

2024-06-27 Thread Axel Boldt-Christmas
> ClassLoaderDataGraph provides APIs for walking different metadata. All the > iterators which are not designed to be used by the GC also keep the holder of > the CLDs alive and by extensions keeps all metadata alive. This is > problematic for concurrent GC as it keeps otherwise unreachable

Re: RFR: 8326820: Metadata artificially kept alive [v4]

2024-06-27 Thread Coleen Phillimore
On Thu, 27 Jun 2024 12:58:44 GMT, Axel Boldt-Christmas wrote: >> ClassLoaderDataGraph provides APIs for walking different metadata. All the >> iterators which are not designed to be used by the GC also keep the holder >> of the CLDs alive and by extensions keeps all metadata alive. This is

Re: RFR: 8326820: Metadata artificially kept alive [v4]

2024-06-27 Thread Axel Boldt-Christmas
> ClassLoaderDataGraph provides APIs for walking different metadata. All the > iterators which are not designed to be used by the GC also keep the holder of > the CLDs alive and by extensions keeps all metadata alive. This is > problematic for concurrent GC as it keeps otherwise unreachable

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-27 Thread Kevin Walls
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help`

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v4]

2024-06-27 Thread Kevin Walls
On Wed, 5 Jun 2024 06:22:17 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request incrementally with one > additional commit since the last revision: > > Add

Re: RFR: 8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed with CPU time out of expected range

2024-06-27 Thread Kevin Walls
On Thu, 27 Jun 2024 08:54:16 GMT, Kevin Walls wrote: > This test has had occasional failures for years, possibly forever. > A previous update made the test "othervm" which removed some interruptions, > but a time accounting problem remains. > > This change adds a simple sleep after observing

RFR: 8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed with CPU time out of expected range

2024-06-27 Thread Kevin Walls
This test has had occasional failures for years, possibly forever. A previous update made the test "othervm" which removed some interruptions, but a time accounting problem remains. This change adds a simple sleep after observing that the test threads are all sleeping. The idea is that threads

Re: RFR: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

2024-06-27 Thread Kevin Walls
On Wed, 26 Jun 2024 17:26:52 GMT, Chris Plummer wrote: > Allow ObjectCollectedException during ThreadReference.toString() call. This > can happen when using SUSPEND_NONE since the thread continues to run after > hitting the breakpoint. > > So far I've just run the test locally. I'll run the

Integrated: 8335154: jcmd VM.classes -verbose=false does not set verbose to false

2024-06-27 Thread Kevin Walls
On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote: > VM.classes uses: > > 995VM_PrintClasses vmop(output(), _verbose.is_set()); > > _verbose.is_set() is wrong: it could be set, but set to false. > > _verbose.value() should be used (see other examples such as >

Re: RFR: 8335154: jcmd VM.classes -verbose=false does not set verbose to false

2024-06-27 Thread Kevin Walls
On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote: > VM.classes uses: > > 995VM_PrintClasses vmop(output(), _verbose.is_set()); > > _verbose.is_set() is wrong: it could be set, but set to false. > > _verbose.value() should be used (see other examples such as >