On Thu, 11 Jul 2024 17:30:21 GMT, Alan Bateman wrote:
> Bringover some of the changes accumulated in the loom repo to the main line,
> most of these changes are test updates and have been baking in the loom repo
> for several months. The motive is partly to reduce the large set of changes
> th
On Mon, 15 Jul 2024 10:21:23 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to fix the
>> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>>
>> The JBS issue has comments which explains what causes the timeout. The
>> commit
On Mon, 15 Jul 2024 10:21:23 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to fix the
>> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>>
>> The JBS issue has comments which explains what causes the timeout. The
>> commit
On Mon, 15 Jul 2024 19:56:13 GMT, Alex Menkov wrote:
>> The change fixes a bug in Attach API implementation on Windows when
>> argument(s) are longer than 1023 bytes
>>
>> testing: test/hotspot/jtreg/serviceability/attach,
>> test/jdk/com/sun/tools/attach on Oracle supported platforms
>
> Alex
On Sat, 13 Jul 2024 14:47:21 GMT, Markus Grönlund wrote:
> Greetings,
>
> Please help review this adjustment, which fixes rare situations where methods
> that have been retransformed or redefined can be perceived as being tagged by
> JFR when they, in fact, are not. The fix unconditionally set
On Mon, 15 Jul 2024 19:56:13 GMT, Alex Menkov wrote:
>> The change fixes a bug in Attach API implementation on Windows when
>> argument(s) are longer than 1023 bytes
>>
>> testing: test/hotspot/jtreg/serviceability/attach,
>> test/jdk/com/sun/tools/attach on Oracle supported platforms
>
> Alex
On Mon, 15 Jul 2024 10:21:23 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to fix the
>> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>>
>> The JBS issue has comments which explains what causes the timeout. The
>> commit
On Tue, 9 Jul 2024 04:43:59 GMT, Chris Plummer wrote:
> The test hits a breakpoint on thread2 with SUSPEND_EVENT_THREAD policy, so
> only thread2 is suspended. It then does a vm.suspend(), which suspends all
> threads and bumps the suspendCount of thread2 up to 2. It then does an
> eventSet.re
On Mon, 15 Jul 2024 18:08:26 GMT, Chris Plummer wrote:
>> The test hits a breakpoint on thread2 with SUSPEND_EVENT_THREAD policy, so
>> only thread2 is suspended. It then does a vm.suspend(), which suspends all
>> threads and bumps the suspendCount of thread2 up to 2. It then does an
>> eventS
On Sat, 13 Jul 2024 06:21:45 GMT, Serguei Spitsyn wrote:
>> Currently Attach operations have restriction for argument size, so setFlag()
>> is expected to fail for long values.
>> This fix adds AttachOperationFailedException for the case on windows,
>> linux/bsd/aix implementations throw generi
On Sat, 13 Jul 2024 01:45:50 GMT, Alex Menkov wrote:
>> test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 79:
>>
>>> 77: // Value length exceeds 1K.
>>> 78: Test withLongValue() {
>>> 79: flagValue = generateValue(1024 + 1);
>>
>> Shouldn't we also be te
> The change fixes a bug in Attach API implementation on Windows when
> argument(s) are longer than 1023 bytes
>
> testing: test/hotspot/jtreg/serviceability/attach,
> test/jdk/com/sun/tools/attach on Oracle supported platforms
Alex Menkov has updated the pull request incrementally with one add
On Mon, 15 Jul 2024 18:08:26 GMT, Chris Plummer wrote:
>> The test hits a breakpoint on thread2 with SUSPEND_EVENT_THREAD policy, so
>> only thread2 is suspended. It then does a vm.suspend(), which suspends all
>> threads and bumps the suspendCount of thread2 up to 2. It then does an
>> eventS
> The test hits a breakpoint on thread2 with SUSPEND_EVENT_THREAD policy, so
> only thread2 is suspended. It then does a vm.suspend(), which suspends all
> threads and bumps the suspendCount of thread2 up to 2. It then does an
> eventSet.resume(), which decrements the thread2 suspendCount to 1,
On Thu, 11 Jul 2024 22:36:05 GMT, Chris Plummer wrote:
>> The test hits a breakpoint on thread2 with SUSPEND_EVENT_THREAD policy, so
>> only thread2 is suspended. It then does a vm.suspend(), which suspends all
>> threads and bumps the suspendCount of thread2 up to 2. It then does an
>> eventS
On Sat, 13 Jul 2024 05:34:24 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
Bringover some of the changes accumulated in the loom repo to the main line,
most of these changes are test updates and have been baking in the loom repo
for several months. The motive is partly to reduce the large set of changes
that have accumulated in the loom repo, and partly to improve robu
> On 14 Jul 2024, at 16:56, Jaroslav Bachorik wrote:
>
>
> The bottom line is that the clustering solution allows specifying JVM options
> and extra resources that will be distributed to all nodes. Hence, if you want
> to add an agent, you need to add the jvn options to point to the location
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
> the use of JNI in the following ways:
>
> * `System::load` and `System::loadLibrary` are now restricted methods
> * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods
> * binding a JNI `native` metho
On Mon, 15 Jul 2024 10:05:24 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> better formatting for transform() method of the test's agent
>
> test/jdk/java/lang/instrument/NativeMethodPrefixApp.ja
> Can I please get a review of this test-only change which proposes to fix the
> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>
> The JBS issue has comments which explains what causes the timeout. The commit
> in this PR addresses those issues by updating the test specif
On Mon, 15 Jul 2024 09:04:24 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to fix the
>> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>>
>> The JBS issue has comments which explains what causes the timeout. The
>> commit
On Mon, 15 Jul 2024 09:04:24 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to fix the
>> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>>
>> The JBS issue has comments which explains what causes the timeout. The
>> commit
On Mon, 15 Jul 2024 08:36:01 GMT, Alan Bateman wrote:
> Would it be possible to at least re-format the declaration of the "transform"
> method as it's very messy and hard to see what is declaration vs. body.
Done.
-
PR Comment: https://git.openjdk.org/jdk/pull/20154#issuecomment-
> Can I please get a review of this test-only change which proposes to fix the
> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>
> The JBS issue has comments which explains what causes the timeout. The commit
> in this PR addresses those issues by updating the test specif
On Mon, 15 Jul 2024 08:16:25 GMT, Jaikiran Pai wrote:
> Hello David,
>
> > @jaikiran there is a lot of unrelated refactoring and style changes here
> > that obscures what the actual fix is.
>
> I've updated the PR to undo some of the cosmetic changes that were introduced
> to cleanup the code
On Mon, 15 Jul 2024 07:00:12 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Fri, 12 Jul 2024 09:22:54 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to fix the
> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>
> The JBS issue has comments which explains what causes the timeout. The commit
> in th
> Can I please get a review of this test-only change which proposes to fix the
> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>
> The JBS issue has comments which explains what causes the timeout. The commit
> in this PR addresses those issues by updating the test specif
On Fri, 12 Jul 2024 09:22:54 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to fix the
> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>
> The JBS issue has comments which explains what causes the timeout. The commit
> in th
31 matches
Mail list logo
