Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v4]

2024-07-20 Thread Chris Plummer
On Sat, 20 Jul 2024 06:33:09 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running

Re: RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v5]

2024-07-20 Thread Thomas Stuefe
On Sat, 20 Jul 2024 11:18:34 GMT, Johan Sjölen wrote: >> src/hotspot/share/prims/wbtestmethods/parserTests.cpp line 132: >> >>> 130:} else if (strcmp(type, "FILE") == 0) { >>> 131: DCmdArgument *argument = >>> 132: new DCmdArgument(name, desc, "FILE", mandatory); >> >> Please

Re: RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v5]

2024-07-20 Thread Johan Sjölen
On Fri, 19 Jul 2024 19:17:54 GMT, Leonid Mesnik wrote: >> Sonia Zaldana Calles has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missing copyright header update > > src/hotspot/share/prims/wbtestmethods/parserTests.cpp line 132: > >>

Re: RFR: 8327054: DiagnosticCommand Compiler.perfmap does not log on output() [v2]

2024-07-20 Thread Thomas Stuefe
On Fri, 19 Jul 2024 20:17:46 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This is a small patch to address >> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making >> `CodeCache::write_perf_map` aware of which output stream errors and warning >> message should be going to. >>

Re: RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v5]

2024-07-20 Thread Thomas Stuefe
On Sat, 20 Jul 2024 07:30:55 GMT, Thomas Stuefe wrote: >> Sonia Zaldana Calles has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missing copyright header update > > src/hotspot/share/services/diagnosticArgument.hpp line 66: > >> 64:

Re: RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v5]

2024-07-20 Thread Thomas Stuefe
On Sat, 20 Jul 2024 07:38:25 GMT, Thomas Stuefe wrote: >> src/hotspot/share/services/diagnosticArgument.cpp line 366: >> >>> 364: _value._name = NEW_C_HEAP_ARRAY(char, JVM_MAXPATHLEN, mtInternal); >>> 365: if (!Arguments::copy_expand_pid(str, len, _value._name, >>> JVM_MAXPATHLEN)) {

Re: RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v5]

2024-07-20 Thread Thomas Stuefe
On Fri, 19 Jul 2024 20:00:28 GMT, Leonid Mesnik wrote: >> Sonia Zaldana Calles has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missing copyright header update > > src/hotspot/share/services/diagnosticArgument.cpp line 366: > >> 364:

Re: RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v5]

2024-07-20 Thread Thomas Stuefe
On Fri, 19 Jul 2024 14:07:12 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492) >> enabling jcmd diagnostic commands that issue an output file to accept the >> `%p` pattern in the file name and substitute it for the

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v4]

2024-07-20 Thread Daniel Lundén
> We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDumpheap.java` with -Xcomp, at least for now. > > ###

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v3]

2024-07-20 Thread Daniel Lundén
On Fri, 19 Jul 2024 16:49:56 GMT, Chris Plummer wrote: > Copyright needs updating. Thanks, done. - PR Comment: https://git.openjdk.org/jdk/pull/20237#issuecomment-2240950444