Re: RFR: 8338890: Add monitoring/management interface for the virtual thread scheduler [v4]

2024-09-08 Thread Alan Bateman
> This PR proposes to add a JDK-specific monitoring and management interface > for the virtual thread scheduler. The interface is named > [VirtualThreadSchedulerMXBean](https://download.java.net/java/early_access/loom/docs/api/jdk.management/jdk/management/VirtualThreadSchedulerMXBean.html) > an

Re: RFR: 8339701: Test TestPinCaseWithCFLH.java fails with -Xcomp

2024-09-08 Thread Alan Bateman
On Sun, 8 Sep 2024 15:30:21 GMT, SendaoYan wrote: > Hi all, > The newly added testcase > `serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java` > fails with `-Xcomp` jvm option. The jvm option `-Xcomp` will make > `BackgroundCompilation` false. In this test, disable `Bac

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

2024-09-08 Thread David Holmes
On Mon, 9 Sep 2024 01:01:41 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/archiveBuilder.cpp line 912: >> >>> 910: >>> STATS_PARAMS(unlinked_klasses), >>> 911: boot_unlinked, >>> platform_unlinked, >>> 912:

Re: RFR: 8339701: Test TestPinCaseWithCFLH.java fails with -Xcomp

2024-09-08 Thread David Holmes
On Sun, 8 Sep 2024 15:30:21 GMT, SendaoYan wrote: > In this test, disable BackgroundCompilation will make instrumentation in > premain throw java.util.MissingResourceException in some test environments. I think we need to understand why this happens, as I don't see this being a test issue. I

Re: RFR: 8337563: NMT: rename MEMFLAGS to MemTag

2024-09-08 Thread David Holmes
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote: > Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`. > > `MEMFLAGS` implies that we can use more than one at the same time, but those > are exclusive values, so `MemTag` is a more suitable name. > > This fix also includes

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

2024-09-08 Thread Ioi Lam
On Sun, 8 Sep 2024 23:46:03 GMT, David Holmes wrote: >> I prefer boot/boot2 to make the output easier to read. Anyone debugging this >> output will need to read the code to understand what "boot2" or >> "boot-nonbase" is. A few extra characters here will not help. > > Sorry but '2' conveys zero

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

2024-09-08 Thread Ioi Lam
On Sun, 8 Sep 2024 23:49:45 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments > > src/hotspot/share/cds/archiveBuilder.cpp line 912: > >> 910:

Re: RFR: 8337563: NMT: rename MEMFLAGS to MemTag

2024-09-08 Thread David Holmes
On Sat, 7 Sep 2024 05:11:25 GMT, Kim Barrett wrote: >> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`. >> >> `MEMFLAGS` implies that we can use more than one at the same time, but those >> are exclusive values, so `MemTag` is a more suitable name. >> >> This fix also includ

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

2024-09-08 Thread David Holmes
On Sat, 7 Sep 2024 00:30:24 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/J

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

2024-09-08 Thread David Holmes
On Fri, 6 Sep 2024 23:53:58 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/archiveBuilder.cpp line 904: >> >>> 902: log_info(cds)("instance classes " STATS_FORMAT, >>> STATS_PARAMS(instance_klasses)); >>> 903: log_info(cds)(" boot " STATS_FORMAT, >>> STATS_PARAMS(boot_

RFR: 8339701: Test TestPinCaseWithCFLH.java fails with -Xcomp

2024-09-08 Thread SendaoYan
Hi all, The newly added testcase `serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java` fails with `-Xcomp` jvm option. The jvm option `-Xcomp` will make `BackgroundCompilation` false. In this test, disable `BackgroundCompilation` will make `instrumentation` in `premain`

Re: RFR: 8339638: Update vmTestbase/nsk/jvmti/*Field*Watch tests to use virtual thread factory

2024-09-08 Thread Abdelhak Zaaim
On Fri, 6 Sep 2024 18:56:32 GMT, Leonid Mesnik wrote: > Field watch tests updated to be executed with virtual threads when virtual > test thread factory enabled.I added > jdk.test.lib.thread.TestThreadFactory > to created test threads so they support virtual thread factory jtreg plugin. > > It