On Tue, 17 Sep 2024 09:24:12 GMT, Thomas Stuefe wrote:
>> Sorry if I'm holding this up. The reasoning did get confusing to me.
>>
>> We are not always good at documenting these commands. But at some point,
>> somebody among us will hopefully document them, or explain it to somebody
>> who wi
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Sat, 14 Sep 2024 06:56:01 GMT, Thomas Stuefe wrote:
>> Hi @tstuefe, it looks like calling
>> [`os::print_memory_mappings`](https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L3785)
>> from the windows implementation of `os::pd_release_memory` is causing the
>>
On Tue, 17 Sep 2024 23:29:46 GMT, Ioi Lam wrote:
>> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> **Overview**
>>
>> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
>> 498](https://bugs.openjdk.org/browse/
On Wed, 18 Sep 2024 01:59:34 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor comment fix
>
> src/hotspot/share/cds/aotClassLinker.hpp line 60:
>
>> 58: // - The visibility of C
>> 59: //
>>
On Wed, 18 Sep 2024 02:57:47 GMT, Ioi Lam wrote:
>> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> **Overview**
>>
>> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
>> 498](https://bugs.openjdk.org/browse/
On Tue, 17 Sep 2024 14:14:31 GMT, Simon Tooke wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires t
> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> **Overview**
>
> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
> 498](https://bugs.openjdk.org/browse/JDK-8315737) and the
> [CSR](https://bugs.openjdk.org/bro
On Tue, 17 Sep 2024 22:07:40 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This PR just replaces `ThreadCritical` with a lock specific to NMT.
>> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
>> I've implemented the new lock with a semaphore so that it can be used
On Tue, 17 Sep 2024 19:52:29 GMT, Ashutosh Mehra wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @ashu-mehra reviews
>
> src/hotspot/share/runtime/threads.cpp line 322:
>
>> 320: universe_post_module_init();
>> 321:
> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> **Overview**
>
> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
> 498](https://bugs.openjdk.org/browse/JDK-8315737) and the
> [CSR](https://bugs.openjdk.org/bro
On Tue, 17 Sep 2024 14:32:22 GMT, Kevin Walls wrote:
>> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
>> should be changed to INT.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> No comma in:
> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> **Overview**
>
> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
> 498](https://bugs.openjdk.org/browse/JDK-8315737) and the
> [CSR](https://bugs.openjdk.org/bro
On Mon, 16 Sep 2024 19:14:01 GMT, Leonid Mesnik wrote:
> The inner 'int max;' declaration hide previous max.
This pull request has now been integrated.
Changeset: 202fd421
Author:Leonid Mesnik
URL:
https://git.openjdk.org/jdk/commit/202fd421f7e8b0f4a9c7393d1045e879acd13e64
Stats:
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote:
>> The inner 'int max;' declaration hide previous max.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - typo fixed.
> - check added.
I filed separate https://bugs
> ### Summary
> This PR just replaces `ThreadCritical` with a lock specific to NMT.
> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
> I've implemented the new lock with a semaphore so that it can be used early
> before VM init. There is also the possibility of addi
On Sat, 14 Sep 2024 06:56:01 GMT, Thomas Stuefe wrote:
>> Hi @tstuefe, it looks like calling
>> [`os::print_memory_mappings`](https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L3785)
>> from the windows implementation of `os::pd_release_memory` is causing the
>>
> ### Summary
> This PR just replaces `ThreadCritical` with a lock specific to NMT.
> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
> I've implemented the new lock with a semaphore so that it can be used early
> before VM init. There is also the possibility of addi
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes
On Mon, 16 Sep 2024 21:54:49 GMT, Ioi Lam wrote:
>> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> **Overview**
>>
>> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
>> 498](https://bugs.openjdk.org/browse/
On Wed, 11 Sep 2024 08:48:42 GMT, Kevin Walls wrote:
> OK thanks, so the change only affects SYSTEM accounts, and such accounts
> already see a different temp path to non-SYSTEM accounts.
>
> Newer and older Java versions run by a SYSTEM account will have different
> temp paths, therefore the
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote:
>> The inner 'int max;' declaration hide previous max.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - typo fixed.
> - check added.
If this is not too late:
it's
On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva
wrote:
>> This patch cleans up the use of `get_new_method()` so callers don't have to
>> worry about throwing `NoSuchMethodError`. The method is refactored to throw
>> the error and avoid ever returning nullptr. Verified with tier1-5 test
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
> should be changed to INT.
Kevin Walls has updated the pull request incrementally with one additional
commit since the last revision:
No comma in: INT followed by...
-
Changes:
- all: https://git.o
On Tue, 17 Sep 2024 13:17:49 GMT, Kevin Walls wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove trailing whitespace
>
> Thanks Thomas -
> It's understood what the info is, main question was when is it useful,
On Tue, 17 Sep 2024 09:24:12 GMT, Thomas Stuefe wrote:
>> Sorry if I'm holding this up. The reasoning did get confusing to me.
>>
>> We are not always good at documenting these commands. But at some point,
>> somebody among us will hopefully document them, or explain it to somebody
>> who wi
> This PR changes the status of realpath() from a Posix-specific API to a
> globally available API, i.e. adding it to the "Hotspot Porting API". Code
> would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires the addition of a stub routine in os_posix.cpp and a Windows
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
> This PR changes the status of realpath() from a Posix-specific API to a
> globally available API, i.e. adding it to the "Hotspot Porting API". Code
> would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires the addition of a stub routine in os_posix.cpp and a Windows
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
> This PR changes the status of realpath() from a Posix-specific API to a
> globally available API, i.e. adding it to the "Hotspot Porting API". Code
> would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires the addition of a stub routine in os_posix.cpp and a Windows
On Tue, 17 Sep 2024 09:35:02 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 11 Sep 2024 11:40:24 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 57 commits:
>>
>> - fix CompressedClassPointersEncodingScheme yet again for linux aarch64
>> - Fixes post-8340
On Tue, 17 Sep 2024 09:59:49 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/classLoaderMetaspace.hpp line 81:
>>
>>> 79: metaspace::MetaspaceArena* class_space_arena() const { return
>>> _class_space_arena; }
>>> 80:
>>> 81: bool have_class_space_arena() const { return _class_
On Wed, 11 Sep 2024 11:29:38 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/metablock.hpp line 52:
>
>> 50: bool is_e
On Wed, 11 Sep 2024 11:25:56 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/metablock.hpp line 48:
>
>> 46:
>> 47: M
On Wed, 11 Sep 2024 13:50:59 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace.cpp line 656:
>
>> 654: // Adjust size
On Wed, 11 Sep 2024 13:05:10 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.cpp line 165:
>
>> 163: MetaBl
On Wed, 11 Sep 2024 12:25:37 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.hpp line 81:
>
>> 79: metaspac
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Mon, 16 Sep 2024 20:36:11 GMT, Kevin Walls wrote:
> Sorry if I'm holding this up. The reasoning did get confusing to me.
>
> We are not always good at documenting these commands. But at some point,
> somebody among us will hopefully document them, or explain it to somebody who
> will. There
On Tue, 17 Sep 2024 08:44:41 GMT, Kevin Walls wrote:
>> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
>> should be changed to INT.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Additional ty
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
> should be changed to INT.
Kevin Walls has updated the pull request incrementally with one additional
commit since the last revision:
Addition INTEGER to standard INT
-
Changes:
- all: https://git.
On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva
wrote:
>> This patch cleans up the use of `get_new_method()` so callers don't have to
>> worry about throwing `NoSuchMethodError`. The method is refactored to throw
>> the error and avoid ever returning nullptr. Verified with tier1-5 test
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
> should be changed to INT.
Kevin Walls has updated the pull request incrementally with one additional
commit since the last revision:
Additional typos/default values
-
Changes:
- all: https://git.o
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote:
>> The inner 'int max;' declaration hide previous max.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - typo fixed.
> - check added.
Marked as reviewed by mli (Rev
47 matches
Mail list logo
