Re: RFR: 8340524: Remove NarrowPtrStruct

2024-09-22 Thread Kim Barrett
On Sat, 21 Sep 2024 06:06:10 GMT, Aleksey Shipilev wrote: >> Please review this change which removes the class NarrowPtrStruct. The only >> place it was still being used was as the type of >> CompressedOops::_narrow_oops. >> Instead, we move the members from NarrowPtrStruct directly into >> Comp

Integrated: 8340524: Remove NarrowPtrStruct

2024-09-22 Thread Kim Barrett
On Sat, 21 Sep 2024 04:19:13 GMT, Kim Barrett wrote: > Please review this change which removes the class NarrowPtrStruct. The only > place it was still being used was as the type of CompressedOops::_narrow_oops. > Instead, we move the members from NarrowPtrStruct directly into > CompressedOops, f

Re: RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v13]

2024-09-22 Thread David Holmes
On Fri, 20 Sep 2024 13:14:54 GMT, Simon Tooke wrote: >> This PR changes the status of realpath() from a Posix-specific API to a >> globally available API, i.e. adding it to the "Hotspot Porting API". Code >> would refer to os::realpath() instead of os::Posix::realpath(). >> >> This requires a

Re: RFR: 8304824: NMT should not use ThreadCritical [v6]

2024-09-22 Thread David Holmes
On Sun, 22 Sep 2024 10:09:00 GMT, Thomas Stuefe wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Inherit from ConditionalMutexLocker. Use current_or_null_safe instead of >> current_or_null. > > src/hotspot/share

Re: RFR: 8304824: NMT should not use ThreadCritical [v6]

2024-09-22 Thread David Holmes
On Fri, 20 Sep 2024 18:11:51 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used

Re: RFR: 8304824: NMT should not use ThreadCritical [v5]

2024-09-22 Thread David Holmes
On Sun, 22 Sep 2024 10:15:29 GMT, Thomas Stuefe wrote: >> src/hotspot/share/runtime/mutexLocker.hpp line 197: >> >>> 195: _mutex(mutex) { >>> 196: bool no_safepoint_check = flag == Mutex::_no_safepoint_check_flag; >>> 197: if (_mutex != nullptr && Thread::current_or_null() != nullptr

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v6]

2024-09-22 Thread Thomas Stuefe
On Fri, 20 Sep 2024 16:56:58 GMT, Matias Saavedra Silva wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix bit counts in GCForwarding > > src/hotspot/share/cds/archiveUtils.cpp line 348: > >> 346: old_tag = (i

Re: RFR: 8340524: Remove NarrowPtrStruct

2024-09-22 Thread Julian Waters
On Sat, 21 Sep 2024 04:19:13 GMT, Kim Barrett wrote: > Please review this change which removes the class NarrowPtrStruct. The only > place it was still being used was as the type of CompressedOops::_narrow_oops. > Instead, we move the members from NarrowPtrStruct directly into > CompressedOops, f

Re: RFR: 8304824: NMT should not use ThreadCritical [v5]

2024-09-22 Thread Thomas Stuefe
On Wed, 18 Sep 2024 00:26:24 GMT, David Holmes wrote: >> Robert Toyonaga has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains five commits: >> >> - Merge master >> - replace tty in pd_release_memory while holding NMT lock. >> - Swit

Re: RFR: 8304824: NMT should not use ThreadCritical [v6]

2024-09-22 Thread Thomas Stuefe
On Fri, 20 Sep 2024 18:11:51 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used