Re: RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v17]

2024-10-09 Thread Simon Tooke
> This PR changes the status of realpath() from a Posix-specific API to a > globally available API, i.e. adding it to the "Hotspot Porting API". Code > would refer to os::realpath() instead of os::Posix::realpath(). > > This requires a Windows implementation of realpath(), using Windows > _ful

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Lutz Schmidt
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has

Re: RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v16]

2024-10-09 Thread Simon Tooke
> This PR changes the status of realpath() from a Posix-specific API to a > globally available API, i.e. adding it to the "Hotspot Porting API". Code > would refer to os::realpath() instead of os::Posix::realpath(). > > This requires a Windows implementation of realpath(), using Windows > _ful

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-09 Thread Serguei Spitsyn
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition > frames hiding mechanism. > Please, see a fix description in the first comment. > > Testing: > - Verified with new test `vthread/CheckHiddenFrames` > - Mach5 tiers 1-6 are passed Serguei Spitsyn has updated the pull re

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v2]

2024-10-09 Thread Serguei Spitsyn
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition > frames hiding mechanism. > Please, see a fix description in the first comment. > > Testing: > - Verified with new test `vthread/CheckHiddenFrames` > - Mach5 tiers 1-6 are passed Serguei Spitsyn has updated the pull re

Re: RFR: 8338603: DiagnosticCommandMBean operations should standardize types for parameters

2024-10-09 Thread Chris Plummer
On Tue, 17 Sep 2024 14:10:07 GMT, Kevin Walls wrote: > DiagnosticCommandImpl should only publish parameter types in a known standard > set, and use "STRING" on anything else. > e.g. We can say "FILE" in the help output for jcmd, as that's for humans, but > the MBean parameter info should contai

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-10-09 Thread Sandhya Viswanathan
On Wed, 9 Oct 2024 17:41:37 GMT, Roberto Castañeda Lozano wrote: >> Yes, @vpaprotsk could review the changes that we made in >> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp. > > Yes, that would be great. In the meantime, I ran a few thousand times the > randomized test `java/lang/Str

Re: RFR: 8341436: containers/docker/TestJcmdWithSideCar.java takes needlessly long to run [v3]

2024-10-09 Thread Kevin Walls
On Mon, 7 Oct 2024 19:37:51 GMT, Sebastian Lövdahl wrote: >> The fix is twofold. >> >> 1. Stop the main container after an iteration is done. The main container is >> started with its runtime defined as 120 seconds, which means that each >> iteration takes 120 seconds. In reality, one iteratio

Re: RFR: 8341138: Rename jtreg property docker.support as container.support

2024-10-09 Thread Severin Gehwolf
On Wed, 9 Oct 2024 14:50:30 GMT, Ramkumar Sunderbabu wrote: > The System property "docker.support" defined in VMProps gives a wrong > impression that it is tied to docker alone. The property is common for any > container runtime. Hence, it needs to be renamed as "container.support". > > Posit

Re: RFR: 8341436: containers/docker/TestJcmdWithSideCar.java takes needlessly long to run [v3]

2024-10-09 Thread Sebastian Lövdahl
On Wed, 9 Oct 2024 11:11:24 GMT, Kevin Walls wrote: >> Sebastian Lövdahl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Have EventGeneratorLoop end after a more predictable duration > > Hmm, actually no I _can_ still get a failure. > >

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Phil Race
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-10-09 Thread Roberto Castañeda Lozano
On Wed, 9 Oct 2024 16:21:53 GMT, Sandhya Viswanathan wrote: >> That seems to work, thanks @rkennke! >> >> Since the [indexOf >> changes](https://github.com/openjdk/jdk/pull/20677/files#diff-ae1139bb5342494f9761e04389b090c543391bfdd7817af1625e854357c96e63) >> are complex and affect the default

Re: RFR: 8338603: DiagnosticCommandMBean operations should standardize types for parameters

2024-10-09 Thread Kevin Walls
On Tue, 17 Sep 2024 14:10:07 GMT, Kevin Walls wrote: > DiagnosticCommandImpl should only publish parameter types in a known standard > set, and use "STRING" on anything else. > e.g. We can say "FILE" in the help output for jcmd, as that's for humans, but > the MBean parameter info should contai

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-10-09 Thread Sandhya Viswanathan
On Wed, 9 Oct 2024 06:25:28 GMT, Roberto Castañeda Lozano wrote: >> Oh! We need to increase the compiler stub size for the indexOf changes. >> Strange that it blows up like this, I was sure there was a better check for >> this somewhere. I changed it like this, let me know if you agree that th

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Chris Plummer
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Chris Plummer
On Wed, 9 Oct 2024 10:36:28 GMT, Matthias Baesken wrote: >> Might be a good idea to have rslt commented out rather than removed outright >> if we don't want to forget about it. guarantee on a variable that doesn't >> exist will be rather confusing to anyone reading through the code > >> Might b

RFR: 8341138: Rename jtreg property docker.support as container.support

2024-10-09 Thread Ramkumar Sunderbabu
The System property "docker.support" defined in VMProps gives a wrong impression that it is tied to docker alone. The property is common for any container runtime. Hence, it needs to be renamed as "container.support". Positive Testing: tier1,tier2,tier3 - to check stability tier5 - to run contai

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Erik Österlund
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341819: LightweightSynchronizer::enter_for races with deflation

2024-10-09 Thread Patricio Chilano Mateo
On Wed, 9 Oct 2024 11:16:46 GMT, Axel Boldt-Christmas wrote: > This is a regression from > [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884). > > When using `+UseObjectMonitorTable` monitors are inflated in a locked state > effectively blocking out deflation. `LightweightSynchronizer

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Stefan Karlsson
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Stefan Karlsson
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Magnus Ihse Bursie
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Axel Boldt-Christmas
> This is the implementation task for `JEP 490: ZGC: Remove the > Non-Generational Mode`. See the JEP for details. > [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) Axel Boldt-Christmas has updated the pull request incrementally with six additional commits since the last revision:

Re: RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v15]

2024-10-09 Thread Simon Tooke
> This PR changes the status of realpath() from a Posix-specific API to a > globally available API, i.e. adding it to the "Hotspot Porting API". Code > would refer to os::realpath() instead of os::Posix::realpath(). > > This requires a Windows implementation of realpath(), using Windows > _ful

RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode

2024-10-09 Thread Axel Boldt-Christmas
This is the implementation task for `JEP 490: ZGC: Remove the Non-Generational Mode`. See the JEP for details. [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) - Commit messages: - Remove XCollectedHeap from HSDB - Fix typo in TestZUncommitEvent.java - Add missing probl

Re: RFR: 8341819: LightweightSynchronizer::enter_for races with deflation

2024-10-09 Thread Roman Kennke
On Wed, 9 Oct 2024 11:16:46 GMT, Axel Boldt-Christmas wrote: > This is a regression from > [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884). > > When using `+UseObjectMonitorTable` monitors are inflated in a locked state > effectively blocking out deflation. `LightweightSynchronizer

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-09 Thread Matthias Baesken
On Tue, 8 Oct 2024 13:38:54 GMT, Matthias Baesken wrote: > There are a few warnings as errors occurring when building on Linux with > clang (clang15). Mostly these are some kind of 'unused' warnings. > Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . I brought back `rslt` but

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Matthias Baesken
> There are a few warnings as errors occurring when building on Linux with > clang (clang15). Mostly these are some kind of 'unused' warnings. > Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . Matthias Baesken has updated the pull request incrementally with one additional commi

RFR: 8341819: LightweightSynchronizer::enter_for races with deflation

2024-10-09 Thread Axel Boldt-Christmas
This is a regression from [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884). When using `+UseObjectMonitorTable` monitors are inflated in a locked state effectively blocking out deflation. `LightweightSynchronizer::enter_for` assumed this to be true. But when the `-UseObjectMonitorTabl

Re: RFR: 8341436: containers/docker/TestJcmdWithSideCar.java takes needlessly long to run [v3]

2024-10-09 Thread Kevin Walls
On Mon, 7 Oct 2024 19:37:51 GMT, Sebastian Lövdahl wrote: >> The fix is twofold. >> >> 1. Stop the main container after an iteration is done. The main container is >> started with its runtime defined as 120 seconds, which means that each >> iteration takes 120 seconds. In reality, one iteratio

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-09 Thread Johan Sjölen
On Wed, 2 Oct 2024 13:28:13 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used e

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-09 Thread Matthias Baesken
On Wed, 9 Oct 2024 07:26:41 GMT, Julian Waters wrote: > Might be a good idea to have rslt commented out Why not; Chris what do you say ? - PR Review Comment: https://git.openjdk.org/jdk/pull/21407#discussion_r1793282296

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods

2024-10-09 Thread Serguei Spitsyn
On Tue, 8 Oct 2024 00:11:12 GMT, Leonid Mesnik wrote: >> This fixes a problem in the VTMS (Virtual Thread Mount State) transition >> frames hiding mechanism. >> Please, see a fix description in the first comment. >> >> Testing: >> - Verified with new test `vthread/CheckHiddenFrames` >> - Mach

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods

2024-10-09 Thread Serguei Spitsyn
On Mon, 7 Oct 2024 23:43:23 GMT, Leonid Mesnik wrote: >> This fixes a problem in the VTMS (Virtual Thread Mount State) transition >> frames hiding mechanism. >> Please, see a fix description in the first comment. >> >> Testing: >> - Verified with new test `vthread/CheckHiddenFrames` >> - Mach

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods

2024-10-09 Thread Serguei Spitsyn
On Mon, 7 Oct 2024 22:41:06 GMT, Leonid Mesnik wrote: >> This fixes a problem in the VTMS (Virtual Thread Mount State) transition >> frames hiding mechanism. >> Please, see a fix description in the first comment. >> >> Testing: >> - Verified with new test `vthread/CheckHiddenFrames` >> - Mach

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-09 Thread Julian Waters
On Wed, 9 Oct 2024 06:25:07 GMT, Matthias Baesken wrote: >> src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c line 393: >> >>> 391: >>> 392: hcreate_r(htab_sz, symtab->hash_table); >>> 393: // guarantee(rslt, "unexpected failure: hcreate_r"); >> >> The commented out guarantee l

Re: RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v14]

2024-10-09 Thread Simon Tooke
> This PR changes the status of realpath() from a Posix-specific API to a > globally available API, i.e. adding it to the "Hotspot Porting API". Code > would refer to os::realpath() instead of os::Posix::realpath(). > > This requires a Windows implementation of realpath(), using Windows > _ful