On Wed, 16 Oct 2024 20:14:07 GMT, Sean Mullan wrote:
>> We've had logging library maintainers on the core-libs-dev several times in
>> the last 7+ years so I hope there is good awareness of StackWalker.
>> SM.getClassContext is legacy, shouldn't be any reason to use it in 2024.
>
> Ok, I'll als
> There is a race between JVMTI NotifyFramePop function and FramePop event
> posting code.
> The fix is to return JVMTI_ERROR_OPAQUE_FRAME if if a FramePop event with
> depth 0 is requested by NotifyFramePop at the time when the target frame is
> in exit epilogue, and MethodExit/FramePop events
On Thu, 17 Oct 2024 00:55:58 GMT, Serguei Spitsyn wrote:
>> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp
>> line 84:
>>
>>> 82: deallocate(jvmti, jni, name);
>>> 83: deallocate(jvmti, jni, (void*)last_notify_method);
>>> 84:
On Wed, 16 Oct 2024 21:50:19 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: resolved comments from Alex and Chris
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStre
On Wed, 16 Oct 2024 21:16:53 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: resolved comments from Alex and Chris
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStre
On Wed, 16 Oct 2024 12:49:34 GMT, Simon Tooke wrote:
>> test/hotspot/gtest/runtime/test_os.cpp line 425:
>>
>>> 423: EXPECT_TRUE(returnedBuffer == nullptr);
>>> 424: #if defined(_WINDOWS)
>>> 425: EXPECT_TRUE(errno == ENAMETOOLONG);
>>
>> Why is this the case? Our implementation does not se
On Wed, 16 Oct 2024 13:17:48 GMT, Simon Tooke wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires a
On Wed, 16 Oct 2024 21:36:02 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: resolved comments from Alex and Chris
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStre
On Wed, 16 Oct 2024 11:14:44 GMT, Kevin Walls wrote:
> This test has been "skipping" since IIOP was removed (jdk 9). Should be
> removed, no impact.
Marked as reviewed by amenkov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21534#pullrequestreview-2373803823
On Tue, 15 Oct 2024 21:59:41 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 692:
>>
>>> 690: if (jt->is_in_VTMS_transition()) {
>>> 691: jvf = check_and_skip_hidden_frames(jt->is_in_VTMS_transition(),
>>> jvf);
>>> 692: } else if (is_virtual) { // filter ou
On Wed, 16 Oct 2024 09:12:56 GMT, Kevin Walls wrote:
>> Man page update for jcmd.
>>
>> Add updates for the filename options/arguments affected by:
>> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
>> substitute PID
>>
>> Also:
>> In the initial "command" summary,
On Wed, 16 Oct 2024 02:28:28 GMT, Serguei Spitsyn wrote:
>> There is a race between JVMTI NotifyFramePop function and FramePop event
>> posting code.
>> The fix is to return JVMTI_ERROR_OPAQUE_FRAME if if a FramePop event with
>> depth 0 is requested by NotifyFramePop at the time when the targe
On Wed, 16 Oct 2024 14:38:13 GMT, Alan Bateman wrote:
>> Thank you for the comment. I can move the try-finally to the method
>> `java/lang/VirtualThread$VThreadContinuation$1.run()` if you prefer. But it
>> will play the same role functionally.
>
> Changing the run method to
>
> vthread.notify
On Wed, 16 Oct 2024 08:00:12 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Disallow NotifyFramePop for
>> enter/enter0/VirtualThread.run/VThreadContinuation.run
>
> src/java.base/share/class
On Wed, 16 Oct 2024 13:28:47 GMT, Weijun Wang wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 16 Oct 2024 06:58:40 GMT, Alan Bateman wrote:
>> Ok, I will revert it.
>
> The description for the SecurityException thrown by these methods were
> adjusted to "if access to the screen is denied by desktop environment". If
> you bring back the paragraphs that were removed then you might
On Wed, 16 Oct 2024 16:04:21 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 16 Oct 2024 15:53:33 GMT, Alan Bateman wrote:
>> **SLF4J** currently depends on this method when logger name mismatch
>> detection is enabled.
>>
>>
>>
>> See also:
>> - https://github.com/qos-ch/slf4j/pul
In this PR, I removed hard-coded security providers and replaced them with a
system property, test.provider.name. If the property is not specified, the
provider originally used in the test is used:
Cipher c = Cipher.getInstance("AES/GCM/NoPadding",
System.getProperty("test.provider.name", "SunJ
On Wed, 16 Oct 2024 02:28:28 GMT, Serguei Spitsyn wrote:
>> There is a race between JVMTI NotifyFramePop function and FramePop event
>> posting code.
>> The fix is to return JVMTI_ERROR_OPAQUE_FRAME if if a FramePop event with
>> depth 0 is requested by NotifyFramePop at the time when the targe
On Wed, 16 Oct 2024 02:28:28 GMT, Serguei Spitsyn wrote:
>> There is a race between JVMTI NotifyFramePop function and FramePop event
>> posting code.
>> The fix is to return JVMTI_ERROR_OPAQUE_FRAME if if a FramePop event with
>> depth 0 is requested by NotifyFramePop at the time when the targe
On Wed, 16 Oct 2024 11:14:44 GMT, Kevin Walls wrote:
> This test has been "skipping" since IIOP was removed (jdk 9). Should be
> removed, no impact.
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21534#pullrequestreview-2373312903
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Tue, 15 Oct 2024 21:21:07 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Disallow NotifyFramePop for
>> enter/enter0/VirtualThread.run/VThreadContinuation.run
>
> src/hotspot/share/prims/jv
On Wed, 16 Oct 2024 14:50:43 GMT, Alan Bateman wrote:
>> The method `java/lang/VirtualThread$VThreadContinuation$1.run()` is starting
>> and finishing in a VTMS transition. The issue is with the JVMTI
>> `NotifyFramePop`. We need a way to disallow adding `FramePop` event requests
>> to its fra
On Wed, 16 Oct 2024 10:30:48 GMT, Ramkumar Sunderbabu
wrote:
>> Passing "-Xmx1g -Xcomp" to the LingeredApp.
>> Testing: tier1
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revision:
>
> change othervm to driver, remove -Xmx1g
On Wed, 16 Oct 2024 10:30:48 GMT, Ramkumar Sunderbabu
wrote:
>> Passing "-Xmx1g -Xcomp" to the LingeredApp.
>> Testing: tier1
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revision:
>
> change othervm to driver, remove -Xmx1g
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Wed, 16 Oct 2024 15:31:49 GMT, ExE Boss wrote:
>> SecurityManager::getClassContext hasn't been needed since JDK 9 but we
>> decided to keep the implementation in case there are older versions of
>> logging libraries that extend SecurityManager so they can call this method.
>> What we have c
On Wed, 16 Oct 2024 13:46:24 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 16 Oct 2024 06:28:03 GMT, Alan Bateman wrote:
>> Thanks, will fix.
>
> SecurityManager::getClassContext hasn't been needed since JDK 9 but we
> decided to keep the implementation in case there are older versions of
> logging libraries that extend SecurityManager so they can call this me
On Wed, 16 Oct 2024 13:46:24 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 16 Oct 2024 10:07:31 GMT, Serguei Spitsyn wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 219:
>>
>>> 217: public void run() {
>>> 218: // notify JVMTI
>>> 219: vthread.notifyJvmtiStart();
>>
>> The notifyJv
On Wed, 16 Oct 2024 10:10:16 GMT, Serguei Spitsyn wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 423:
>>
>>> 421: }
>>> 422:
>>> 423: } finally {
>>
>> This means an empty finally block, I assume you'll remove the try-finally
>> here.
>
> T
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Wed, 16 Oct 2024 12:13:32 GMT, Coleen Phillimore wrote:
> We're seeing failures in our nightly testing for tests
> runtime/cds/appcds/SharedBaseAddress.java and
> runtime/cds/SharedBaseAddress.java which I'm tracking in this bug
> [JDK-8340212](https://bugs.openjdk.org/browse/JDK-8340212)
>
On Mon, 7 Oct 2024 19:37:51 GMT, Sebastian Lövdahl wrote:
>> The fix is twofold.
>>
>> 1. Stop the main container after an iteration is done. The main container is
>> started with its runtime defined as 120 seconds, which means that each
>> iteration takes 120 seconds. In reality, one iteratio
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
> This PR changes the status of realpath() from a Posix-specific API to a
> globally available API, i.e. adding it to the "Hotspot Porting API". Code
> would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires a Windows implementation of realpath(), using Windows
> _ful
On Wed, 16 Oct 2024 00:03:32 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up test code
>
> Hi @stooke , I was away on vacation when you made the updates.
>
> I'm afraid I still have some
> This PR changes the status of realpath() from a Posix-specific API to a
> globally available API, i.e. adding it to the "Hotspot Porting API". Code
> would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires a Windows implementation of realpath(), using Windows
> _ful
On Wed, 16 Oct 2024 00:02:13 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up test code
>
> test/hotspot/gtest/runtime/test_os.cpp line 413:
>
>> 411:
>> 412: TEST_VM(os, realpath) {
>> 4
On Tue, 15 Oct 2024 23:52:35 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up test code
>
> test/hotspot/gtest/runtime/test_os.cpp line 422:
>
>> 420: errno = 0;
>> 421: const char* re
On Wed, 16 Oct 2024 09:31:12 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
This test has been "skipping" since IIOP was removed (jdk 9). Should be
removed, no impact.
-
Commit messages:
- 8342338: Remove redundant IIOPURLTest.java
Changes: https://git.openjdk.org/jdk/pull/21534/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21534&range=00
Iss
> Passing "-Xmx1g -Xcomp" to the LingeredApp.
> Testing: tier1
Ramkumar Sunderbabu has updated the pull request incrementally with one
additional commit since the last revision:
change othervm to driver, remove -Xmx1g
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21519/fil
On Wed, 16 Oct 2024 08:00:48 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Disallow NotifyFramePop for
>> enter/enter0/VirtualThread.run/VThreadContinuation.run
>
> src/java.base/share/class
On Wed, 16 Oct 2024 08:05:20 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Disallow NotifyFramePop for
>> enter/enter0/VirtualThread.run/VThreadContinuation.run
>
> src/java.base/share/class
On Tue, 15 Oct 2024 21:26:55 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Disallow NotifyFramePop for
>> enter/enter0/VirtualThread.run/VThreadContinuation.run
>
> src/hotspot/share/prims/jv
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Tue, 15 Oct 2024 22:31:27 GMT, Volodymyr Paprotski wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix aarch64.ad
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 1634:
>
>> 1632:
>> 1633:
>> 1
On Wed, 31 Jul 2024 08:30:47 GMT, Kevin Walls wrote:
> Man page update for jcmd.
>
> Add updates for the filename options/arguments affected by:
> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
> substitute PID
>
> Also:
> In the initial "command" summary, remove t
> Man page update for jcmd.
>
> Add updates for the filename options/arguments affected by:
> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
> substitute PID
>
> Also:
> In the initial "command" summary, remove the text about "If the pid is 0.."
> as it is completel
On Tue, 15 Oct 2024 22:09:54 GMT, Volodymyr Paprotski wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix aarch64.ad
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 1659:
>
>> 1657: Label L_moreT
On Tue, 15 Oct 2024 21:30:13 GMT, Volodymyr Paprotski wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix aarch64.ad
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 414:
>
>> 412: // to the valid
On Tue, 15 Oct 2024 18:57:11 GMT, Phil Race wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main chan
On Wed, 9 Oct 2024 22:58:33 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - Ma
On Wed, 9 Oct 2024 22:58:33 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - Ma
On Tue, 15 Oct 2024 23:40:41 GMT, Ioi Lam wrote:
>> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> **Overview**
>>
>> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
>> 498](https://bugs.openjdk.org/browse/
On Tue, 15 Oct 2024 22:16:27 GMT, Sean Mullan wrote:
>> src/java.desktop/share/classes/java/awt/Robot.java line 433:
>>
>>> 431: * then a {@code SecurityException} may be thrown,
>>> 432: * or the content of the returned {@code Color} is undefined.
>>> 433: *
>>
>> This text sho
60 matches
Mail list logo
