On Thu, 31 Oct 2024 03:52:31 GMT, Dean Long wrote:
> For some reason github thinks VirtualThreadPinnedEvent.java was renamed to
> libSynchronizedNative.c and libTracePinnedThreads.c was renamed to
> LockingMode.java. Is there a way to fix that?
I don't think which view this is but just to say
On Mon, 28 Oct 2024 08:34:14 GMT, Alan Bateman wrote:
> This is an update to the Virtual thread implementation that we'd like to
> integrate in advance of JEP 491.
>
> The update removes the use of "temporary transitions", basically cases where
> the thread identity switches to the carrier th
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 19:01:03 GMT, Patricio Chilano Mateo
wrote:
>>> One way to get rid of this would be to have c2 just set last_Java_pc too
>>> along with last_Java_sp, so we don't need to push lr to be able to do
>>> last_Java_sp[-1] to make the frame walkable.
>>
>> If that would solve the
On Tue, 29 Oct 2024 22:15:16 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/code/nmethod.cpp line 1302:
>>
>>> 1300: _compiler_type = type;
>>> 1301: _orig_pc_offset = 0;
>>> 1302: _num_stack_arg_slots = 0;
>>
>> Was the old value wrong, unneeded, or
On Thu, 31 Oct 2024 01:32:19 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typos in comments
>
> src/hotspot/share/runtime/objectMonitor.inline.hpp line 207:
>
>> 205: }
>> 206:
>>
On Wed, 30 Oct 2024 20:31:44 GMT, Justin Lu wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address other cases in Hotspot
>
> Thank you for the review.
@justin-curtis-lu for future reference note that hotspot gener
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Fri, 25 Oct 2024 18:14:38 GMT, Ashutosh Mehra wrote:
>> src/hotspot/share/classfile/systemDictionaryShared.cpp line 685:
>>
>>> 683: InstanceKlass* ik = InstanceKlass::cast(k);
>>> 684:
>>> 685: if (SafepointSynchronize::is_at_safepoint()) {
>>
>> Why is this piece of block required
On Fri, 25 Oct 2024 15:02:30 GMT, Ashutosh Mehra wrote:
>> Ioi Lam has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8342907: Implement AOT testing mode for jtreg tests (authored by
>> @katyapav)
>> - disable test that fails with hotsp
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 23:05:20 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 696:
>
>> 694:
On Wed, 30 Oct 2024 19:06:58 GMT, Coleen Phillimore wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add klass_name check for is_object_wait0
>> - Fix comment in continuation.hpp
>
> src/hotspot/share/r
On Wed, 30 Oct 2024 22:11:38 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/continuation.hpp line 50:
>>
>>> 48: class JavaThread;
>>> 49:
>>> 50: // should match Continuation.PreemptStatus() in Continuation.java
>>
>> As far as I can tell, these enum values still don't match
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 30 Oct 2024 19:02:05 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1411:
>>
>>> 1409: // zero out fields (but not the stack)
>>> 1410: const size_t hs = oopDesc::header_size();
>>> 1411: oopDesc::set_klass_gap(mem, 0);
>>
>> Why,
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Tue, 29 Oct 2024 20:57:48 GMT, Dean Long wrote:
>> No, it just happens to be stored at the sender_sp marker. We were already
>> making room for two words but only using one.
>
> `sender_sp_offset` is listed under "All frames", but I guess that's wrong and
> should be changed. Can we fix the
On Wed, 30 Oct 2024 00:52:32 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add klass_name check for is_object_wait0
>> - Fix comment in continuation.hpp
>
> src/hotspot/cpu/x86/interp_
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Wed, 30 Oct 2024 01:52:30 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - SmallRegisterMap::instance() fix + comment typo
>> - Add comment in call_VM_preemptable
>
> src/hotspot/share
On Wed, 31 Jul 2024 08:30:47 GMT, Kevin Walls wrote:
> Man page update for jcmd.
>
> Add updates for the filename options/arguments affected by:
> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
> substitute PID
>
> Also:
> In the initial "command" summary, remove t
On Fri, 25 Oct 2024 21:51:53 GMT, Justin Lu wrote:
> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
> `ExceptionOccurred()` when the usage is treating the return value as a
> boolean. This is part of the bigger umbrella issue:
> [JDK-8341542](https://bugs.openjdk.org/brows
On Wed, 30 Oct 2024 20:16:52 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Mon, 28 Oct 2024 22:02:02 GMT, Patricio Chilano Mateo
wrote:
>> That said such a scenario is not about concurrently pushing the same thread
>> to the list from different threads. So I'm still somewhat confused about the
>> concurrency control here. Specifically I can't see how the cmpxchg o
On Tue, 29 Oct 2024 00:19:29 GMT, Justin Lu wrote:
>> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
>> `ExceptionOccurred()` when the usage is treating the return value as a
>> boolean. This is part of the bigger umbrella issue:
>> [JDK-8341542](https://bugs.openjdk.org/b
On Wed, 30 Oct 2024 19:11:46 GMT, Ioi Lam wrote:
>> A thought for a possible cleanup, after this PR is done…
>>
>> The scratch mirror logic had me… scratching my head. It seems to me that a
>> more descriptive name would make the code explain itself better. I suggest
>> (for a future cleanup
On Tue, 29 Oct 2024 02:56:30 GMT, Serguei Spitsyn wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1082:
>
>> 1080:
On Fri, 25 Oct 2024 20:44:25 GMT, Roger Riggs wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Update
On Thu, 17 Oct 2024 16:12:26 GMT, Kevin Walls wrote:
>> Man page update for jcmd.
>>
>> Add updates for the filename options/arguments affected by:
>> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
>> substitute PID
>>
>> Also:
>> In the initial "command" summary,
On Mon, 21 Oct 2024 09:55:53 GMT, Axel Boldt-Christmas
wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename oopCont + fix in JvmtiUnmountBeginMark
>
> src/hotspot/share/runtime/continuationFreezeThaw.c
On Tue, 29 Oct 2024 14:19:05 GMT, Weijun Wang wrote:
>> test/jdk/javax/xml/crypto/dsig/ErrorHandlerPermissions.java line 1:
>>
>>> 1: /*
>>
>> @wangweij It looks like this test can be deleted as it was specifically
>> trying to check that a `SecurityException` wasn't thrown, or did you think
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Wed, 30 Oct 2024 09:44:42 GMT, Serguei Spitsyn wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add klass_name check for is_object_wait0
>> - Fix comment in continuation.hpp
>
> src/hotspot/share/run
On Tue, 29 Oct 2024 18:35:05 GMT, Brent Christian wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 186 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Update copyrigh
On Mon, 28 Oct 2024 20:12:27 GMT, Roger Riggs wrote:
> Reviewed all tests under test/jaxp/javax/xml/jaxp. A few imports moved around
> unnecessarily but otherwise looks fine.
JAXP test comments fixed in
https://github.com/openjdk/jdk/pull/21498/commits/5577e4884710eba498ee5f40fa85d47eaa07364d
On Fri, 25 Oct 2024 21:18:41 GMT, Sean Mullan wrote:
> Comments on `java.security` classes.
>
> Also, I'd like to see some clarifications on what "the installed policy" or
> "the current policy" is. The `ProtectionDomain` mentions this when talking
> about dynamic permissions. On the other han
On Wed, 30 Oct 2024 02:09:46 GMT, Liang Mao wrote:
>> We disabled tiered compilation to force everything to compile through C2 to
>> get more consistent results.
>
> @earthling-amzn ，thanks for providing your options. Looks like disabling
> pacing would help the score.
>
> -XX:+UseShenandoahG
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Tue, 29 Oct 2024 17:07:56 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/Font.java line 1613:
>>
>>> 1611: * interpreted as a {@code Font} object according to the
>>> 1612: * specification of {@code Font.decode(String)}
>>> 1613: * If the specified prope
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Tue, 29 Oct 2024 23:16:29 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1411:
>
>> 1409
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main changes in the JEP and also includes an apidiff of the specif
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Thu, 24 Oct 2024 06:14:18 GMT, John R Rose wrote:
> A thought for a possible cleanup, after this PR is done…
>
> The scratch mirror logic had me… scratching my head. It seems to me that a
> more descriptive name would make the code explain itself better. I suggest
> (for a future cleanup) c
On Thu, 17 Oct 2024 16:12:26 GMT, Kevin Walls wrote:
>> Man page update for jcmd.
>>
>> Add updates for the filename options/arguments affected by:
>> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
>> substitute PID
>>
>> Also:
>> In the initial "command" summary,
On Wed, 16 Oct 2024 18:47:44 GMT, Matthew Donovan wrote:
> In this PR, I removed hard-coded security providers and replaced them with a
> system property, test.provider.name. If the property is not specified, the
> provider originally used in the test is used:
>
> Cipher c = Cipher.getInstance
On Wed, 30 Oct 2024 18:12:30 GMT, Matthew Donovan wrote:
>> In this PR, I removed hard-coded security providers and replaced them with a
>> system property, test.provider.name. If the property is not specified, the
>> provider originally used in the test is used:
>>
>> Cipher c = Cipher.getIns
On Fri, 25 Oct 2024 22:44:49 GMT, Alex Menkov wrote:
> The fix enables logging in the test agent to get more details about
> intermittent failures.
This pull request has now been integrated.
Changeset: 1b177ce5
Author:Alex Menkov
URL:
https://git.openjdk.org/jdk/commit/1b177ce5b7e2
> In this PR, I removed hard-coded security providers and replaced them with a
> system property, test.provider.name. If the property is not specified, the
> provider originally used in the test is used:
>
> Cipher c = Cipher.getInstance("AES/GCM/NoPadding",
> System.getProperty("test.provider.
On Wed, 30 Oct 2024 12:11:26 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix 32/64-bit confusion in comment in VirtualMachineImpl.c
>
> make/hotspot/gensrc/GensrcAdlc.gmk line 50:
>
On Wed, 30 Oct 2024 17:20:49 GMT, Larry Cable wrote:
>> the implementation I originally provided does not in fact solve the issue!
>>
>> the attach protocol initiation "handshake" requires that the "attacher" (the
>> caller of this code) and the "attachee"(the target JVM to be "attached" to)
>
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 30 Oct 2024 14:48:46 GMT, Matthew Donovan wrote:
>> In this PR, I removed hard-coded security providers and replaced them with a
>> system property, test.provider.name. If the property is not specified, the
>> provider originally used in the test is used:
>>
>> Cipher c = Cipher.getIns
On Wed, 30 Oct 2024 14:48:46 GMT, Matthew Donovan wrote:
>> In this PR, I removed hard-coded security providers and replaced them with a
>> system property, test.provider.name. If the property is not specified, the
>> provider originally used in the test is used:
>>
>> Cipher c = Cipher.getIns
> the implementation I originally provided does not in fact solve the issue!
>
> the attach protocol initiation "handshake" requires that the "attacher" (the
> caller of this code) and the "attachee"(the target JVM to be "attached" to)
> *must* share a "/tmp" (or access to the attachee's `cwd`)
> In this PR, I removed hard-coded security providers and replaced them with a
> system property, test.provider.name. If the property is not specified, the
> provider originally used in the test is used:
>
> Cipher c = Cipher.getInstance("AES/GCM/NoPadding",
> System.getProperty("test.provider.
On Mon, 28 Oct 2024 16:12:39 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This PR just replaces `ThreadCritical` with a lock specific to NMT.
>> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
>> I've implemented the new lock with a semaphore so that it can be used
On Tue, 22 Oct 2024 15:52:27 GMT, Ramkumar Sunderbabu
wrote:
> Merging vm folder's InMemoryJavaCompiler into jdk folder's merge
> InMemoryJavaCompiler so that maintenance is easy.
>
> Testing done for
> Tiers 1,2,3
> test/hotspot/jtreg tests
This pull request has now been integrated.
Changes
On Wed, 30 Oct 2024 12:30:25 GMT, Julian Waters wrote:
>> I'm glad you're giving some TLC to adlc. It is in desperate need of it.
>
> TLC?
https://www.vocabulary.com/dictionary/TLC
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1822628499
On Mon, 28 Oct 2024 16:12:39 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This PR just replaces `ThreadCritical` with a lock specific to NMT.
>> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
>> I've implemented the new lock with a semaphore so that it can be used
On Mon, 28 Oct 2024 16:12:39 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This PR just replaces `ThreadCritical` with a lock specific to NMT.
>> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
>> I've implemented the new lock with a semaphore so that it can be used
On Thu, 17 Oct 2024 16:12:26 GMT, Kevin Walls wrote:
>> Man page update for jcmd.
>>
>> Add updates for the filename options/arguments affected by:
>> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
>> substitute PID
>>
>> Also:
>> In the initial "command" summary,
On Mon, 28 Oct 2024 16:12:39 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This PR just replaces `ThreadCritical` with a lock specific to NMT.
>> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
>> I've implemented the new lock with a semaphore so that it can be used
On Wed, 30 Oct 2024 13:39:00 GMT, Robert Toyonaga wrote:
>I'm not certain, but looking at it again, it seems that the ThreadCritical
>uses in ChunkPool::deallocate_chunk and ChunkPool::prune() are only needed for
>NMT and are independent of the other ThreadCritical uses in that code.
At least
On Tue, 29 Oct 2024 19:08:12 GMT, Larry Cable wrote:
>> src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java line
>> 114:
>>
>>> 112: String.format("Unable to open socket file %s:
>>> " +
>>> 113: "target process %d doesn't res
On Wed, 30 Oct 2024 13:09:26 GMT, Matthew Donovan wrote:
>> In this PR, I removed hard-coded security providers and replaced them with a
>> system property, test.provider.name. If the property is not specified, the
>> provider originally used in the test is used:
>>
>> Cipher c = Cipher.getIns
On Mon, 28 Oct 2024 08:34:14 GMT, Alan Bateman wrote:
> This is an update to the Virtual thread implementation that we'd like to
> integrate in advance of JEP 491.
>
> The update removes the use of "temporary transitions", basically cases where
> the thread identity switches to the carrier th
On Wed, 30 Oct 2024 12:32:17 GMT, Johan Sjölen wrote:
>>> Hi @tstuefe,
>>>
>>> > Ah thank you. I think I added that printing ages ago. I should not have
>>> > used tty. The immediate solution to get you going may be to just change
>>> > this from tty to fileStream fs(stderr);
>>>
>>> Thanks!
On Tue, 29 Oct 2024 20:22:03 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
> In this PR, I removed hard-coded security providers and replaced them with a
> system property, test.provider.name. If the property is not specified, the
> provider originally used in the test is used:
>
> Cipher c = Cipher.getInstance("AES/GCM/NoPadding",
> System.getProperty("test.provider.
On Wed, 18 Sep 2024 05:53:05 GMT, Thomas Stuefe wrote:
>> Hi @roberttoyonaga
>>
>> (Pinging @afshin-zafari and @jdksjolen)
>>
>> First off, it is good that you ran into this since it highlights a possible
>> real deadlock. Both locks are quite coarse. I cannot think from the top of
>> my hea
On Wed, 30 Oct 2024 11:19:03 GMT, Magnus Ihse Bursie wrote:
>> src/hotspot/share/adlc/main.cpp line 494:
>>
>>> 492: }
>>> 493:
>>> 494: #if !defined(_WIN32) || defined(_WIN64)
>>
>> Removing the conditionalization is fine for this change. But see also
>> https://bugs.openjdk.org/browse/JDK-
On Wed, 30 Oct 2024 11:05:17 GMT, Magnus Ihse Bursie wrote:
>> make/scripts/compare.sh line 1457:
>>
>>> 1455: THIS_SEC_BIN="$THIS_SEC_DIR/sec-bin.zip"
>>> 1456: if [ "$OPENJDK_TARGET_OS" = "windows" ]; then
>>> 1457: JGSS_WINDOWS_BIN="jgss-windows-x64-bin.zip"
>>
>>
On Wed, 30 Oct 2024 03:24:48 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Error in os_windows.cpp for unknown cpu
>
> src/java.base/windows/native/libjava/gdefs_md.h line 31:
>
>> 29:
>>
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Wed, 30 Oct 2024 03:13:02 GMT, Kim Barrett wrote:
>> It's something we do in our build. For us, _LP64 really means 64 bit
>
> It seems like the `_WIN64` check here was never useful. It's also been there
> since before the
> mercurial age.
The "mercurial age". Sounds like something in-betwee
On Wed, 30 Oct 2024 03:05:32 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Error in os_windows.cpp for unknown cpu
>
> src/hotspot/share/adlc/main.cpp line 494:
>
>> 492: }
>> 493:
>> 494
On Wed, 30 Oct 2024 00:07:33 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adlc need _CRT_NONSTDC_NO_WARNINGS as well... *sigh*
>
> src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp line 1433:
>
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Fri, 25 Oct 2024 08:25:21 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Tue, 8 Oct 2024 07:20:49 GMT, Axel Boldt-Christmas
wrote:
> This is the implementation task for `JEP 490: ZGC: Remove the
> Non-Generational Mode`. See the JEP for details.
> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
This pull request has now been integrated.
Changeset: 8
On Tue, 29 Oct 2024 23:48:22 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix 32/64-bit confusion in comment in VirtualMachineImpl.c
>
> make/scripts/compare.sh line 79:
>
>> 77:
>> 78:
On Wed, 30 Oct 2024 02:18:00 GMT, David Holmes wrote:
>> Yes. As Julian says, it's something we set up in our builds:
>>
>> if test "x$FLAGS_CPU_BITS" = x64; then
>> $1_DEFINES_CPU_JDK="${$1_DEFINES_CPU_JDK} -D_LP64=1"
>> $1_DEFINES_CPU_JVM="${$1_DEFINES_CPU_JVM} -D_LP64=1"
>> fi
>
>
On Wed, 30 Oct 2024 02:23:20 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix 32/64-bit confusion in comment in VirtualMachineImpl.c
>
> src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp
On Fri, 25 Oct 2024 08:25:21 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 12:40:59 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
95 matches
Mail list logo
