Re: RFR: 8352098: -Xrunjdwp fails on static JDK

2025-03-17 Thread David Holmes
On Mon, 17 Mar 2025 19:37:48 GMT, Jiangli Zhou wrote: > Please review this fix that avoids `JvmtiAgent::convert_xrun_agent` from > prematurely exiting VM if `lookup_On_Load_entry_point` cannot load the agent > using `JVM_OnLoad` symbol. Thanks > > `lookup_On_Load_entry_point` first tries to lo

Re: RFR: 8352180: AttachListenerThread causes many tests to timeout on Windows

2025-03-17 Thread David Holmes
On Tue, 18 Mar 2025 00:16:40 GMT, Alex Menkov wrote: > The change fixes regression from JDK-8319055 (see David's evaluation in the > CR description) > > Testing: sanity tier1; > tier6, tier7 - in progress Fix looks good. Any idea on why things are taking so long? Is the pipe undersized? Th

Re: RFR: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055

2025-03-17 Thread David Holmes
On Tue, 18 Mar 2025 02:00:17 GMT, David Holmes wrote: >> The change fixes crash on AIX after JDK-8319055 >> Can't test it on AIX, but the reason is obvious from the stack trace. >> AIX is the only platform that does not implement `reply_writer` yet >> >> Testing: sanity tier1 > > src/hotspot/sha

Re: RFR: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055

2025-03-17 Thread David Holmes
On Mon, 17 Mar 2025 20:35:58 GMT, Alex Menkov wrote: > The change fixes crash on AIX after JDK-8319055 > Can't test it on AIX, but the reason is obvious from the stack trace. > AIX is the only platform that does not implement `reply_writer` yet > > Testing: sanity tier1 This is obviously a nece

RFR: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055

2025-03-17 Thread Alex Menkov
The change fixes crash on AIX after JDK-8319055 Can't test it on AIX, but the reason is obvious from the stack trace. AIX is the only platform that does not implement `reply_writer` yet Testing: sanity tier1 - Commit messages: - fix Changes: https://git.openjdk.org/jdk/pull/24089/f

RFR: 8352098: -Xrunjdwp fails on static JDK

2025-03-17 Thread Jiangli Zhou
Please review this fix that avoids `JvmtiAgent::convert_xrun_agent` from prematurely exiting VM if `lookup_On_Load_entry_point` cannot load the agent using `JVM_OnLoad` symbol. Thanks `lookup_On_Load_entry_point` first tries to load the builtin agent from the executable by checking the requeste

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-17 Thread snake66
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote: >> @magicus why can't we just use `-pthread` everywhere? My recollection is >> that `-pthread` both sets compiler directives needed for pthread programming >> and links to libpthread, so it seems to be what we should be using. ?? > >> Anothe