RFR: 8355221: Get rid of unnecessary override of JDIBase.breakpointForCommunication in nsk/jdi tests

2025-04-22 Thread Chris Plummer
The following tests all override the JDIBase.breakpointForCommunication() method, but no longer need too: vmTestbase/nsk/jdi/ClassPrepareRequest/addClassExclusionFilter/filter003.java vmTestbase/nsk/jdi/ClassPrepareRequest/addClassFilter_rt/filter_rt002.java vmTestbase/nsk/jdi/ClassPrepareRequest

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v3]

2025-04-22 Thread Daniel Jeliński
On Tue, 22 Apr 2025 21:29:01 GMT, Daniel Jeliński wrote: >> Currently if loading a core file fails, the diagnostic information provided >> on different systems is different; on MacOS we produce an error message, >> while on Linux we only print information if debug logging is enabled. >> >> Thi

Integrated: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled

2025-04-22 Thread Daniel Jeliński
On Thu, 17 Apr 2025 12:27:55 GMT, Daniel Jeliński wrote: > Currently if loading a core file fails, the diagnostic information provided > on different systems is different; on MacOS we produce an error message, > while on Linux we only print information if debug logging is enabled. > > This PR

Re: RFR: 8355069: Allocation::check_out_of_memory() should support CheckUnhandledOops mode [v2]

2025-04-22 Thread Serguei Spitsyn
On Sat, 19 Apr 2025 02:25:33 GMT, Leonid Mesnik wrote: >> The >> CheckUnhandledOops >> cause failure if JvmtiExport::post_resource_exhausted(...) >> is called in >> MemAllocator::Allocation::check_out_of_memory() >> The obj is null so it is not a real bug. >> >> I am fixing it to reduce noise f

RFR: 8355214: nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001.java should use JDIBase superclass

2025-04-22 Thread Chris Plummer
There is nsk/jdi superclass called JDIBase that many tests inherit from. It provides common functionality like log support, basic event handling, support for setting a breakpoint, and support for the communcation breakpoint that the debugger and debuggee used to synchronize with. addthreadfilter

RFR: 8355211: nsk/jdi/EventRequest/disable/disable001.java should use JDIBase superclass

2025-04-22 Thread Chris Plummer
There is an nsk/jdi superclass called JDIBase that many tests inherit from. It provides common functionality like log support, basic event handling, support for setting a breakpoint, and support for the communication breakpoint that the debugger and debuggee use to synchronize with. disable001 d

Integrated: 8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication

2025-04-22 Thread Chris Plummer
On Sat, 19 Apr 2025 05:19:22 GMT, Chris Plummer wrote: > Remove the need for many nsk/jdi tests to discover the main thread, resulting > in the test needing to be run with includevirtualthreads=y. Details in first > comment. > > Tested with all tier2, tier3, and tier5 svc tests This pull requ

Re: RFR: 8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication [v3]

2025-04-22 Thread Chris Plummer
On Mon, 21 Apr 2025 21:58:17 GMT, Chris Plummer wrote: >> Remove the need for many nsk/jdi tests to discover the main thread, >> resulting in the test needing to be run with includevirtualthreads=y. >> Details in first comment. >> >> Tested with all tier2, tier3, and tier5 svc tests > > Chris

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v3]

2025-04-22 Thread Kevin Walls
On Tue, 22 Apr 2025 21:29:01 GMT, Daniel Jeliński wrote: >> Currently if loading a core file fails, the diagnostic information provided >> on different systems is different; on MacOS we produce an error message, >> while on Linux we only print information if debug logging is enabled. >> >> Thi

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

2025-04-22 Thread Kevin Walls
On Tue, 22 Apr 2025 21:30:47 GMT, Daniel Jeliński wrote: >>> I'll modify the Linux Pgrab to report all errors through the exception >>> message, and remove print_error from Pgrab. >> >> That would be great. There is some existing fragmentation/platform >> differences here, so I don't think yo

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v3]

2025-04-22 Thread Chris Plummer
On Tue, 22 Apr 2025 21:29:01 GMT, Daniel Jeliński wrote: >> Currently if loading a core file fails, the diagnostic information provided >> on different systems is different; on MacOS we produce an error message, >> while on Linux we only print information if debug logging is enabled. >> >> Thi

Re: RFR: 8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication [v3]

2025-04-22 Thread Leonid Mesnik
On Mon, 21 Apr 2025 21:58:17 GMT, Chris Plummer wrote: >> Remove the need for many nsk/jdi tests to discover the main thread, >> resulting in the test needing to be run with includevirtualthreads=y. >> Details in first comment. >> >> Tested with all tier2, tier3, and tier5 svc tests > > Chris

Re: RFR: 8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication [v3]

2025-04-22 Thread Alex Menkov
On Mon, 21 Apr 2025 21:58:17 GMT, Chris Plummer wrote: >> Remove the need for many nsk/jdi tests to discover the main thread, >> resulting in the test needing to be run with includevirtualthreads=y. >> Details in first comment. >> >> Tested with all tier2, tier3, and tier5 svc tests > > Chris

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

2025-04-22 Thread Daniel Jeliński
On Fri, 18 Apr 2025 18:15:21 GMT, Chris Plummer wrote: > Please run all the SA tests in test/hotspot/jtreg/serviceability/sa and > test/jdk/sun/tools/jhsdb on all our supported platforms. Local testing on Linux completed successfully; had to reconfigure ptrace, otherwise many tests were skippe

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

2025-04-22 Thread Daniel Jeliński
On Tue, 22 Apr 2025 19:16:39 GMT, Kevin Walls wrote: >> ah, interesting. The native caller doesn't print the error message, it >> throws a Java exception with the message in the exception string, and the >> Java code then deals with the exception. >> >> This is different on MacOS, where the er

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v3]

2025-04-22 Thread Daniel Jeliński
> Currently if loading a core file fails, the diagnostic information provided > on different systems is different; on MacOS we produce an error message, > while on Linux we only print information if debug logging is enabled. > > This PR adds some new messages on Linux to match MacOSX, and change

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

2025-04-22 Thread Kevin Walls
On Tue, 22 Apr 2025 16:34:07 GMT, Daniel Jeliński wrote: > I'll modify the Linux Pgrab to report all errors through the exception > message, and remove print_error from Pgrab. That would be great. There is some existing fragmentation/platform differences here, so I don't think you need to mak

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

2025-04-22 Thread Daniel Jeliński
On Tue, 22 Apr 2025 09:47:02 GMT, Kevin Walls wrote: >> src/jdk.hotspot.agent/linux/native/libsaproc/ps_proc.c line 450: >> >>> 448: if ( (ph = (struct ps_prochandle*) calloc(1, sizeof(struct >>> ps_prochandle))) == NULL) { >>> 449: snprintf(err_buf, err_buf_len, "can't allocate memory fo

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock [v5]

2025-04-22 Thread duke
On Wed, 9 Apr 2025 13:43:01 GMT, Robert Toyonaga wrote: >> ### Update: >> After some discussion it was decided it's not necessary to expand the lock >> scope for reserve/commit. Instead, we are opting to add comments explaining >> the reasons for locking and the conditions to avoid which could

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock [v5]

2025-04-22 Thread Robert Toyonaga
On Wed, 9 Apr 2025 13:43:01 GMT, Robert Toyonaga wrote: >> ### Update: >> After some discussion it was decided it's not necessary to expand the lock >> scope for reserve/commit. Instead, we are opting to add comments explaining >> the reasons for locking and the conditions to avoid which could

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

2025-04-22 Thread Kevin Walls
On Tue, 22 Apr 2025 09:28:52 GMT, Kevin Walls wrote: >> Daniel Jeliński has updated the pull request incrementally with eight >> additional commits since the last revision: >> >> - Update copyright >> - Add more error messages >> - Add more error messages >> - Add more error messages >> -

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

2025-04-22 Thread Kevin Walls
On Fri, 18 Apr 2025 09:30:24 GMT, Daniel Jeliński wrote: >> Currently if loading a core file fails, the diagnostic information provided >> on different systems is different; on MacOS we produce an error message, >> while on Linux we only print information if debug logging is enabled. >> >> Thi

Re: RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v2]

2025-04-22 Thread Kevin Walls
On Fri, 18 Apr 2025 09:30:24 GMT, Daniel Jeliński wrote: >> Currently if loading a core file fails, the diagnostic information provided >> on different systems is different; on MacOS we produce an error message, >> while on Linux we only print information if debug logging is enabled. >> >> Thi