Re: RFR: 8355453: nsk.share.jdi.Debugee.waitingEvent() does not timeout properly [v2]

2025-04-28 Thread Chris Plummer
On Mon, 28 Apr 2025 23:35:49 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> return null instead of throwing an exception > > test/hotspot/jtreg/vmTestbase/nsk/share/jdi/Debugee.java line 463:

Re: RFR: 8355453: nsk.share.jdi.Debugee.waitingEvent() does not timeout properly [v2]

2025-04-28 Thread Serguei Spitsyn
On Fri, 25 Apr 2025 06:17:38 GMT, Chris Plummer wrote: >> nsk.share.jdi.Debugee.waitingEvent() takes a timeout argument. However, if >> the call to EventQueue.remove() times out and returns null, waitingEvent() >> just keep on retrying. The logic is incorrect for a null result. It should >> im

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v5]

2025-04-28 Thread Serguei Spitsyn
On Mon, 28 Apr 2025 19:30:27 GMT, Kevin Walls wrote: >> This issue was hard to reproduce or had stopped happening, but was likely a >> failure to capture the main arguments from a monitored process, caused by >> slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most >> like

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v5]

2025-04-28 Thread Leonid Mesnik
On Mon, 28 Apr 2025 19:30:27 GMT, Kevin Walls wrote: >> This issue was hard to reproduce or had stopped happening, but was likely a >> failure to capture the main arguments from a monitored process, caused by >> slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most >> like

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v5]

2025-04-28 Thread Chris Plummer
On Mon, 28 Apr 2025 19:30:27 GMT, Kevin Walls wrote: >> This issue was hard to reproduce or had stopped happening, but was likely a >> failure to capture the main arguments from a monitored process, caused by >> slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most >> like

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v5]

2025-04-28 Thread Kevin Walls
On Mon, 28 Apr 2025 19:30:27 GMT, Kevin Walls wrote: >> This issue was hard to reproduce or had stopped happening, but was likely a >> failure to capture the main arguments from a monitored process, caused by >> slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most >> like

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v4]

2025-04-28 Thread Magnus Ihse Bursie
On Mon, 28 Apr 2025 09:15:28 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store me

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v5]

2025-04-28 Thread Kevin Walls
> This issue was hard to reproduce or had stopped happening, but was likely a > failure to capture the main arguments from a monitored process, caused by > slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most > likely the same issue and increasing ARGS_ATTEMPTS has been see

Re: RFR: 8355453: nsk.share.jdi.Debugee.waitingEvent() does not timeout properly [v2]

2025-04-28 Thread Leonid Mesnik
On Fri, 25 Apr 2025 06:17:38 GMT, Chris Plummer wrote: >> nsk.share.jdi.Debugee.waitingEvent() takes a timeout argument. However, if >> the call to EventQueue.remove() times out and returns null, waitingEvent() >> just keep on retrying. The logic is incorrect for a null result. It should >> im

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v4]

2025-04-28 Thread Kevin Walls
On Sun, 27 Apr 2025 21:05:34 GMT, Kevin Walls wrote: >> This issue was hard to reproduce or had stopped happening, but was likely a >> failure to capture the main arguments from a monitored process, caused by >> slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most >> like

Re: RFR: 8355569: Some nsk/jdi tests can glean the "main" thread by using the ClassPrepareEvent for the debuggee main class [v3]

2025-04-28 Thread Chris Plummer
On Mon, 28 Apr 2025 19:09:59 GMT, Chris Plummer wrote: >> As part of the work for >> [JDK-8353955](https://bugs.openjdk.org/browse/JDK-8353955) I am reducing the >> number of tests that need to be run with includevirtualhreads=y due to using >> JDI to lookup threads in the debuggee. There are

Re: RFR: 8355569: Some nsk/jdi tests can glean the "main" thread by using the ClassPrepareEvent for the debuggee main class [v3]

2025-04-28 Thread Chris Plummer
> As part of the work for > [JDK-8353955](https://bugs.openjdk.org/browse/JDK-8353955) I am reducing the > number of tests that need to be run with includevirtualhreads=y due to using > JDI to lookup threads in the debuggee. There are many tests that lookup the > "main" thread. They can instead

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v4]

2025-04-28 Thread Igor Veresov
On Mon, 28 Apr 2025 17:35:13 GMT, Vladimir Kozlov wrote: > Looks better. There are still places where UL is used specifically for TD > processing. Consider using `(aot, training)` there instead of `(cds)`. Right. I haven't addressed these review comments yet. - PR Comment: https:/

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v4]

2025-04-28 Thread Vladimir Kozlov
On Mon, 28 Apr 2025 09:15:28 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store me

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v4]

2025-04-28 Thread Chris Plummer
On Sun, 27 Apr 2025 21:05:34 GMT, Kevin Walls wrote: >> This issue was hard to reproduce or had stopped happening, but was likely a >> failure to capture the main arguments from a monitored process, caused by >> slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most >> like

Re: RFR: 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1

2025-04-28 Thread PAWAN CHAWDHARY
On Mon, 28 Apr 2025 15:51:44 GMT, PAWAN CHAWDHARY wrote: > 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 TestDockerMemoryMetricsSubgroup.java creates directory under /sys/fs/cgroup by running following command for this test needs to be run as root mode `mkdir -p /sys/fs

RFR: 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1

2025-04-28 Thread PAWAN CHAWDHARY
8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 - Commit messages: - 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 Changes: https://git.openjdk.org/jdk/pull/24930/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24930&range=00

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v4]

2025-04-28 Thread Erik Joelsson
On Mon, 28 Apr 2025 09:15:28 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store me

RFR: 8355692: Refactor stream indentation

2025-04-28 Thread Joel Sikström
Hello, > To make it easier to review this PR, each commit that is prefixed with "FIX:" > has the command/method I've used to verify that the output of prints is not > changed/broken. The goal of this PR is to refactor the usage of streamIndentor and StreamAutoIndentor and combine them into a s

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v4]

2025-04-28 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v3]

2025-04-28 Thread Kevin Walls
On Mon, 28 Apr 2025 04:27:03 GMT, Chris Plummer wrote: >> Yes -- Maybe just take out this extra timeout. I'm being too respectful of >> things that have been in the test forever, but aren't of much use. Some >> tests have their own timeouts, when jtreg can just time them out. >> >> Checking

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v3]

2025-04-28 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Integrated: 8355617: Remove historical debug_only macro in favor of DEBUG_ONLY

2025-04-28 Thread Aleksey Shipilev
On Fri, 25 Apr 2025 15:17:17 GMT, Aleksey Shipilev wrote: > I noticed in `macros.hpp`: > > > #ifdef ASSERT > #define DEBUG_ONLY(code) code > #define NOT_DEBUG(code) > #define NOT_DEBUG_RETURN /*next token must be ;*/ > // Historical. > #define debug_only(code) code > #else // ASSERT > > > The

Re: RFR: 8355617: Remove historical debug_only macro in favor of DEBUG_ONLY

2025-04-28 Thread Aleksey Shipilev
On Fri, 25 Apr 2025 15:17:17 GMT, Aleksey Shipilev wrote: > I noticed in `macros.hpp`: > > > #ifdef ASSERT > #define DEBUG_ONLY(code) code > #define NOT_DEBUG(code) > #define NOT_DEBUG_RETURN /*next token must be ;*/ > // Historical. > #define debug_only(code) code > #else // ASSERT > > > The

Re: RFR: 8352075: Perf regression accessing fields [v3]

2025-04-28 Thread Radim Vansa
On Mon, 28 Apr 2025 07:41:23 GMT, Radim Vansa wrote: >> This optimization is a followup to https://github.com/openjdk/jdk/pull/24290 >> trying to reduce the performance regression in some scenarios introduced in >> https://bugs.openjdk.org/browse/JDK-8292818 . Based both on performance and >>

Re: RFR: 8352075: Perf regression accessing fields [v3]

2025-04-28 Thread Radim Vansa
> This optimization is a followup to https://github.com/openjdk/jdk/pull/24290 > trying to reduce the performance regression in some scenarios introduced in > https://bugs.openjdk.org/browse/JDK-8292818 . Based both on performance and > memory consumption it is a (better) alternative to > https