Re: RFR: 8359366: RunThese30M.java EXCEPTION_ACCESS_VIOLATION in JvmtiBreakpoints::clearall_in_class_at_safepoint

2025-06-29 Thread Leonid Mesnik
On Mon, 30 Jun 2025 04:42:59 GMT, David Holmes wrote: >> The segv/eav happens in the case if JvmtiBreakpoint::_method's class >> redefined old between getting the Method* from jmethodid in the >> JvmtiEnv::SetBreakpoint(Method* method, jlocation location) {..} and >> and actual setting breakpo

Re: RFR: 8359707: Add classfile modification code to RedefineClassHelper [v8]

2025-06-29 Thread David Holmes
On Fri, 27 Jun 2025 11:37:30 GMT, Coleen Phillimore wrote: >> I copied this code for another test in the Valhalla repo and thought it >> would be a good utility function. It might be better written using the >> Classfile API. >> Tested with test. > > Coleen Phillimore has updated the pull requ

Re: RFR: 8359366: RunThese30M.java EXCEPTION_ACCESS_VIOLATION in JvmtiBreakpoints::clearall_in_class_at_safepoint

2025-06-29 Thread Leonid Mesnik
On Mon, 30 Jun 2025 04:58:32 GMT, David Holmes wrote: > Approach seems reasonable but it is worrisome that we still have these kinds > of issues with class redefinition! And why has this suddenly appeared? Did a > recent code change introduce this bug? There are few things to note here: 1) I r

Re: RFR: 8359366: RunThese30M.java EXCEPTION_ACCESS_VIOLATION in JvmtiBreakpoints::clearall_in_class_at_safepoint

2025-06-29 Thread David Holmes
On Sat, 28 Jun 2025 05:02:56 GMT, Leonid Mesnik wrote: > The segv/eav happens in the case if JvmtiBreakpoint::_method's class > redefined old between getting the Method* from jmethodid in the > JvmtiEnv::SetBreakpoint(Method* method, jlocation location) {..} and > and actual setting breakpoint

RFR: 8359366: RunThese30M.java EXCEPTION_ACCESS_VIOLATION in JvmtiBreakpoints::clearall_in_class_at_safepoint

2025-06-29 Thread Leonid Mesnik
The segv/eav happens in the case if JvmtiBreakpoint::_method's class redefined old between getting the Method* from jmethodid in the JvmtiEnv::SetBreakpoint(Method* method, jlocation location) {..} and and actual setting breakpoint in the VM operation VM_ChangeBreakpoints. Here are details: The