Re: RFR: 8330606: Redefinition doesn't but should verify the new klass [v3]

2025-07-16 Thread Amit Kumar
On Thu, 6 Feb 2025 18:41:12 GMT, Coleen Phillimore wrote: > It might be that you need to add some nop() bytecode or something to > generate the code attribute? @coleenp This seems like a valid solution. By the way, can we modify this testcase in OpenJDK or should the OpenJ9 team make the chan

Re: RFR: 8358890: VM option -XX:AllowRedefinitionToAddDeleteMethods should be obsoleted then expired [v6]

2025-07-16 Thread Leonid Mesnik
On Thu, 17 Jul 2025 01:57:32 GMT, Serguei Spitsyn wrote: >> The VM option -XX:AllowRedefinitionToAddDeleteMethods was added in JDK 13 as >> a temporary backward compatibility flag under JDK-8192936 and was >> immediately marked as Deprecate. The fix is to obsolete this option in JDK >> 26 and

Re: RFR: 8358890: VM option -XX:AllowRedefinitionToAddDeleteMethods should be obsoleted then expired [v6]

2025-07-16 Thread Serguei Spitsyn
> The VM option -XX:AllowRedefinitionToAddDeleteMethods was added in JDK 13 as > a temporary backward compatibility flag under JDK-8192936 and was immediately > marked as Deprecate. The fix is to obsolete this option in JDK 26 and expire > in JDK 27. > > TBD: Need to submit a related CSR. > >

Re: RFR: 8361751: Test sun/tools/jcmd/TestJcmdSanity.java timed out on Windows

2025-07-16 Thread David Holmes
On Wed, 16 Jul 2025 20:44:05 GMT, Alex Menkov wrote: > Tests which run serviceability tools to attach to the main test process can > get deadlock with streaming output (see #24672 ) > The fix disables attach streaming output for tests in jdk/sun/tools/jcmd > > Testing: tier6, tier7 Okay, but a

Integrated: 8309399: JVMTI spec needs to clarify when OPAQUE_FRAME is thrown for reasons other than a native method

2025-07-16 Thread Serguei Spitsyn
On Thu, 3 Jul 2025 06:05:26 GMT, Serguei Spitsyn wrote: > It was decided in a local discussion with Chris and Alan to update the JVMTI > spec to make descriptions/clarifications of some `JVMTI_ERROR_OPAQUE_FRAME` > cases more consistent. > This impacts the following JVMTI spec sections: > - `

Re: RFR: 8361751: Test sun/tools/jcmd/TestJcmdSanity.java timed out on Windows

2025-07-16 Thread Chris Plummer
On Wed, 16 Jul 2025 20:44:05 GMT, Alex Menkov wrote: > Tests which run serviceability tools to attach to the main test process can > get deadlock with streaming output (see #24672 ) > The fix disables attach streaming output for tests in jdk/sun/tools/jcmd > > Testing: tier6, tier7 Marked as r

RFR: 8361751: Test sun/tools/jcmd/TestJcmdSanity.java timed out on Windows

2025-07-16 Thread Alex Menkov
Tests which run serviceability tools to attach to the main test process can get deadlock with streaming output (see #24672 ) The fix disables attach streaming output for tests in jdk/sun/tools/jcmd Testing: tier6, tier7 - Commit messages: - fix Changes: https://git.openjdk.org/jdk

Re: RFR: 8309400: JDI spec needs to clarify when OpaqueFrameException and NativeMethodException are thrown [v2]

2025-07-16 Thread Alex Menkov
On Wed, 16 Jul 2025 03:32:34 GMT, Chris Plummer wrote: >> Fix how ThreadReference.popFrame() and ThreadReference.forceEarlyReturn deal >> with JDWP OPAQUE_FRAME error. >> >> Before virtual threads, OpaqueFrameException did not exist and these API >> always threw NativeMethodException when JDWP

Re: [jdk25] RFR: 8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError

2025-07-16 Thread Leonid Mesnik
On Wed, 16 Jul 2025 06:24:16 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [cbb3d23e](https://github.com/openjdk/jdk/commit/cbb3d23e19a8a893bf2fbda03e7bda4f4b7a59a6) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk25. > > > Test-

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-07-16 Thread Matthias Baesken
On Wed, 21 May 2025 09:18:56 GMT, Magnus Ihse Bursie wrote: > So if you think you want to do this library by library, then do so, and if > so keep this PR A lib by lib approach is probably easier to discuss/review. Changing all (or most) JDK native libs at once will probably make some people

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-07-16 Thread Matthias Baesken
On Wed, 9 Apr 2025 20:34:42 GMT, Chris Plummer wrote: > > Wait, `LOW` is `-O2`? 👀 I thought it was like no optimization at all. I'm > > sooo confused with these levels. So maybe going from `LOW` to `SIZE` will > > actually lose more optimization than I thought. _sigh_ > > -Os is the same as -O