On Mon, 11 Jul 2022 14:58:07 GMT, Axel Boldt-Christmas <d...@openjdk.org> wrote:
> Currently the `RegisterMap` constructor uses implicit boolean arguments to > configure its function. Implicit boolean arguments makes code harder to > understand and reason about at the call site. Using explicit scoped enums > instead makes it both clear what is being configured and the type safety > makes mistakes less likely. > > Update `RegisterMap` constructors to use these scoped enum types instead of > booleans. > ```C++ > enum class UpdateMap { skip, yes }; > enum class ProcessFrames { skip, yes }; > enum class WalkContinuation { skip, yes }; > > > Testing: tier1-3 This pull request has now been integrated. Changeset: 2f3e494b Author: Axel Boldt-Christmas <axel.boldt-christ...@oracle.com> Committer: Erik Ă–sterlund <eosterl...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/2f3e494b80cce8e357ceac9a897c42d7e8f54af5 Stats: 434 lines in 40 files changed: 317 ins; 0 del; 117 mod 8290074: Remove implicit arguments for RegisterMap constructor Reviewed-by: eosterlund, tschatzl ------------- PR: https://git.openjdk.org/jdk/pull/9455