On Fri, 14 Jun 2024 16:37:15 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> The vmTestbase/vm/share is a shared test library for vmTestbase tests. This > library contains a lot of code that is used by only by small number of tests > or not used at all. There are no plans to actively develop new tests in > vmTestsbase and improve this shared library. > The final goal of this and the following PRs is to reduce the maintenance > cost of vmTestbase by eliminating this library. > > Also, this PR moves test-specific code into corresponding test directories to > increase code locality. This allows later easier move tests from vmTestbase. > > The few remaining classes include > InMemoryJavaCompiler.java > that is very similar to same class from the standard testlibrary and could be > merge with it and > ProcessUtils.java > which is used by > test/hotspot/jtreg/runtime/Thread/TestBreakSignalThreadDump.java > and thus should be moved into the standard testlibrary. > The stack and options might be merged in nsk/share test library. This pull request has now been integrated. Changeset: a81e1bf1 Author: Leonid Mesnik <lmes...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/a81e1bf1e1a6f00280b9be987c03fe20915fd52c Stats: 1669 lines in 45 files changed: 27 ins; 1595 del; 47 mod 8332252: Clean up vmTestbase/vm/share Reviewed-by: cjplummer ------------- PR: https://git.openjdk.org/jdk/pull/19727