RE: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Langer, Christoph
serviceability-dev@openjdk.org > Subject: Re: Submitted JEP: Asynchronous Stack Trace VM API > > Johannes -- I just now noticed that you’re not yet a Committer, so per the JEP > process [1] you can author but not submit or own a JEP. > > Christoph, Jaroslav -- as active JDK Project Reviewe

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Bechberger, Johannes
...@datadoghq.com , serviceability-dev@openjdk.org Subject: Re: Submitted JEP: Asynchronous Stack Trace VM API Johannes -- I just now noticed that you’re not yet a Committer, so per the JEP process [1] you can author but not submit or own a JEP. Christoph, Jaroslav -- as active JDK Project Reviewers

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Mark Reinhold
Johannes -- I just now noticed that you’re not yet a Committer, so per the JEP process [1] you can author but not submit or own a JEP. Christoph, Jaroslav -- as active JDK Project Reviewers, would one of you be willing to be the owner of record for this JEP? - Mark [1] https://cr.openjdk.java.n

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Bechberger, Johannes
: Asynchronous Stack Trace VM API 2022/11/1 1:15:13 -0700, johannes.bechber...@sap.com: > Thanks for your corrections. I only corrected one minor thing: I > removed “; in a JDK image it should be copied into the `include` > directory”, as I forgot to remove after moving the header to a > locat

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Mark Reinhold
2022/11/1 1:15:13 -0700, johannes.bechber...@sap.com: > Thanks for your corrections. I only corrected one minor thing: I > removed “; in a JDK image it should be copied into the `include` > directory”, as I forgot to remove after moving the header to a > location which is auto copied. What’s impor

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-01 Thread Bechberger, Johannes
Date: Tuesday, 1. November 2022 at 01:35 To: Bechberger, Johannes Cc: andrei.pan...@gmail.com , Langer, Christoph , jaroslav.bacho...@datadoghq.com , serviceability-dev@openjdk.org Subject: Re: Submitted JEP: Asynchronous Stack Trace VM API I’ve edited the text of this JEP in JBS to tighten the

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-31 Thread Mark Reinhold
I’ve edited the text of this JEP in JBS to tighten the prose, correct terminology, and fix a few formatting issues. HTML and diffs attached for reference. Please review and make any necessary corrections, then I’ll move it to Candidate. - Mark Title: JEP TBD: Asynchronous Stack Trace VM API JEP

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-27 Thread Mark Reinhold
2022/10/27 13:49:52 -0700, johannes.bechber...@sap.com: >> For IP clarity, could you please also move the demo into the same > sandbox branch? You can place it under src/demo/share for now. > > What do you mean with the demo? My demo repository with the modified > async-profiler? Yes. >

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-27 Thread Bechberger, Johannes
(as far I understand it). Regards Johannes From: Mark Reinhold Date: Thursday, 27. October 2022 at 22:24 To: Bechberger, Johannes Cc: andrei.pan...@gmail.com , Langer, Christoph , jaroslav.bacho...@datadoghq.com , serviceability-dev@openjdk.org Subject: Re: Submitted JEP: Asynchronous Stack Tr

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-27 Thread Mark Reinhold
2022/10/11 1:18:19 -0700, johannes.bechber...@sap.com: > Thanks for your comments. I incorporated them in the updated version > of the JEP and updated all related repositories that now are > implemented based on current JDK20 head and async-profiler head. The > implementation of the JEP now resides

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-26 Thread Bechberger, Johannes
JEP: Asynchronous Stack Trace VM API Thanks for your comments. I incorporated them in the updated version of the JEP and updated all related repositories that now are implemented based on current JDK20 head and async-profiler head. The implementation of the JEP now resides in the sandbox

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-11 Thread Bechberger, Johannes
Thanks for your comments. I incorporated them in the updated version of the JEP and updated all related repositories that now are implemented based on current JDK20 head and async-profiler head. The implementation of the JEP now resides in the sandbox repository too. Regards Johannes From: Ma

RE: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-05 Thread Lindenmaier, Goetz
Hi, I appreciate a lot the new name, especially replacing call trace by stack trace, because it is stack traces that are handled by the API. Maybe adding "native" might be a good idea, because it can also handle native frames? I think this is a distinguishing feature of this API. Best regards,