On Wed, 22 Jun 2022 16:46:54 GMT, Severin Gehwolf wrote:
>> Oops! previously I was not know that I should not force push and should not
>> edit commit message so this time I took care of those points. But, rebase is
>> also not suggested :(
>> I did so because after making suggested review chan
On Thu, 23 Jun 2022 16:16:00 GMT, Jayashree Huttanagoudar
wrote:
> > > ```
> > > $ git add
> > > $ git commit --amend --no-edit
> > > ```
> >
> >
> > The `git commit --amend` changes the current commit. Don't use `--amend`
> > and it should be fine.
>
> Ok thank you.
I tried just :
# git
On Wed, 22 Jun 2022 14:08:41 GMT, Jayashree Huttanagoudar
wrote:
>> This PR is to address :
>> https://bugs.openjdk.org/browse/JDK-8135292?jql=labels%20%3D%20starter-bug
>> Verified the build before and after the patch. Also below tests are run:
>> Before Patch:
>>
>> $ make test TEST="jtreg:t
On Wed, 22 Jun 2022 16:48:33 GMT, Severin Gehwolf wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8135291: Removed duplicate code in Address.java and related files in SA
>> -After asLongValue() added t
On Wed, 22 Jun 2022 14:08:41 GMT, Jayashree Huttanagoudar
wrote:
>> This PR is to address :
>> https://bugs.openjdk.org/browse/JDK-8135292?jql=labels%20%3D%20starter-bug
>> Verified the build before and after the patch. Also below tests are run:
>> Before Patch:
>>
>> $ make test TEST="jtreg:t
On Wed, 22 Jun 2022 14:44:02 GMT, Jayashree Huttanagoudar
wrote:
> ```
> $ git add
> $ git commit --amend --no-edit
>```
The `git commit --amend` changes the current commit. Don't use `--amend` and it
should be fine.
-
PR: https://git.openjdk.org/jdk/pull/9112
On Wed, 22 Jun 2022 14:08:41 GMT, Jayashree Huttanagoudar
wrote:
>> This PR is to address :
>> https://bugs.openjdk.org/browse/JDK-8135292?jql=labels%20%3D%20starter-bug
>> Verified the build before and after the patch. Also below tests are run:
>> Before Patch:
>>
>> $ make test TEST="jtreg:t
> This PR is to address :
> https://bugs.openjdk.org/browse/JDK-8135292?jql=labels%20%3D%20starter-bug
> Verified the build before and after the patch. Also below tests are run:
> Before Patch:
>
> $ make test TEST="jtreg:test/hotspot/jtreg/serviceability"
> ==
>
