Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v2]

2024-04-02 Thread Coleen Phillimore
> Remove the notproduct distinction for command line options, rather than > trying to wrestle the macros to fix the bug that they've been treated as > develop options for some time now. This simplifies the command line option > macros. > > Tested with tier1-4, tier1 on Oracle platforms. Also

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v2]

2024-04-02 Thread Ioi Lam
On Tue, 2 Apr 2024 16:21:15 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v2]

2024-04-02 Thread Stefan Karlsson
On Tue, 2 Apr 2024 16:24:19 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v2]

2024-04-02 Thread Coleen Phillimore
On Tue, 2 Apr 2024 16:24:19 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v2]

2024-04-02 Thread Coleen Phillimore
On Tue, 2 Apr 2024 16:49:19 GMT, Stefan Karlsson wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Clean up notproduct from tests. > > src/hotspot/share/runtime/arguments.cpp line 3420: > >> 3418: static void a