Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread Daohan Qu
On Thu, 22 Jun 2023 13:44:53 GMT, Daniel D. Daugherty wrote: >> Daohan Qu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add a simple check > > Folks the GHA for this PR reported a failure in > serviceability/sa/ClhsdbDumpclass > on w

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread Daniel D . Daugherty
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote: >> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s >> `buildreplayjars` command. This bug manifests itself during my diagnosing >> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be >> fixed

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread Daohan Qu
On Thu, 22 Jun 2023 08:59:42 GMT, Kevin Walls wrote: > I see the failure too. javap needs "-v" to show the StackMap info, I see that > on linux release and debug builds. Exactly! @kevinjwalls. And a situation similar to [this one](https://github.com/openjdk/jdk/pull/3004#issuecomment-800679752

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread Kevin Walls
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote: >> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s >> `buildreplayjars` command. This bug manifests itself during my diagnosing >> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be >> fixed

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread Daohan Qu
On Thu, 22 Jun 2023 07:38:21 GMT, David Holmes wrote: > What output is the test looking for i.e why is supposed to be writing it? If > it is the if (DEBUG) debugMessage(...) calls they are not enabled. It is looking for `StackMapTable` info in the javap output. > I've filed https://bugs.openjd

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread Daohan Qu
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote: >> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s >> `buildreplayjars` command. This bug manifests itself during my diagnosing >> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be >> fixed

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread David Holmes
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote: >> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s >> `buildreplayjars` command. This bug manifests itself during my diagnosing >> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be >> fixed

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread Daohan Qu
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote: >> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s >> `buildreplayjars` command. This bug manifests itself during my diagnosing >> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be >> fixed

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-22 Thread David Holmes
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote: >> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s >> `buildreplayjars` command. This bug manifests itself during my diagnosing >> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be >> fixed

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-21 Thread Chris Plummer
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote: >> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s >> `buildreplayjars` command. This bug manifests itself during my diagnosing >> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be >> fixed

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files [v3]

2023-06-21 Thread Daohan Qu
> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s > `buildreplayjars` command. This bug manifests itself during my diagnosing > [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be > fixed first. > > I have run jtreg test `tier1-3` of release bu