On Tue, 11 Apr 2023 01:05:49 GMT, Leonid Mesnik wrote:
>> Updated VM internal object allocation C2 intrinsic to post jvmti events when
>> needed.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed after Sergey's commen
On Tue, 11 Apr 2023 01:05:49 GMT, Leonid Mesnik wrote:
>> Updated VM internal object allocation C2 intrinsic to post jvmti events when
>> needed.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed after Sergey's commen
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote:
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
I have simplified #if #else #endif and renamed functions and variables. Also,
changed _should_notify_object_alloc default value to false.
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
fixed after Sergey's comments
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Mon, 10 Apr 2023 22:03:56 GMT, Leonid Mesnik wrote:
>> src/hotspot/share/prims/jvmtiEventController.cpp line 727:
>>
>>> 725: JvmtiExport::set_should_post_on_exceptions((any_env_thread_enabled
>>> & SHOULD_POST_ON_EXCEPTIONS_BITS) != 0);
>>> 726:
>>> 727: JvmtiExport::_should_post_a
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote:
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
src/hotspot/share/prims/jvmtiExport.cpp line 1050:
> 1048:
> 1049: // This flag is read by C2 during VM internal objects allocation
> 1050: bool Jvmti
On Mon, 10 Apr 2023 22:02:10 GMT, Leonid Mesnik wrote:
>> src/hotspot/share/opto/library_call.cpp line 2856:
>>
>>> 2854: set_result(ideal.value(result));
>>> 2855: return true;
>>> 2856: #else
>>
>> Nit: It is better to replace #else at 2856 with #endif. Then #endif at 2859
>> is not need
On Mon, 10 Apr 2023 18:46:42 GMT, Serguei Spitsyn wrote:
>> Updated VM internal object allocation C2 intrinsic to post jvmti events when
>> needed.
>
> src/hotspot/share/opto/library_call.cpp line 2856:
>
>> 2854: set_result(ideal.value(result));
>> 2855: return true;
>> 2856: #else
>
> Ni
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote:
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
src/hotspot/share/prims/jvmtiEventController.cpp line 727:
> 725: JvmtiExport::set_should_post_on_exceptions((any_env_thread_enabled &
> SHOULD_PO
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote:
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
It looks pretty good. But I'd like to request a couple of changes.
The `notify_allocation` sounds to generic.
What about to replace it with `notify_jvmt
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote:
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
Good.
-
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13312#pullrequestreview-1376633778
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote:
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
Tested with all CI tests.
-
PR Comment: https://git.openjdk.org/jdk/pull/13312#issuecomment-1500670951
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote:
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
Thanks to Vladimir K for fix in escape.cpp.
-
PR Comment: https://git.openjdk.org/jdk/pull/13312#issuecomment-1500656370
Updated VM internal object allocation C2 intrinsic to post jvmti events when
needed.
-
Commit messages:
- fixed EA
- Merge branch 'master' of https://github.com/openjdk/jdk into 8277573
- 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate
objects
Change
14 matches
Mail list logo
