On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik wrote:
> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
> output of non-generation (ZGC) GC as valid.
Looks good to me.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.
On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik wrote:
> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
> output of non-generation (ZGC) GC as valid.
Marked as reviewed by cjplummer (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9604
On Wed, 27 Jul 2022 21:39:47 GMT, Leonid Mesnik wrote:
>> I meant shouldn't we see ZGC failures before your changes. Otherwise I don't
>> understand why this change is needed.
>
> Before my changes test just silently ignored any GC setting and always use G1.
Ah, ok. That makes sense now.
-
On Fri, 22 Jul 2022 19:27:29 GMT, Chris Plummer wrote:
>> No, test passes with ZGC.
>
> I meant shouldn't we see ZGC failures before your changes. Otherwise I don't
> understand why this change is needed.
Before my changes test just silently ignored any GC setting and always use G1.
--
On Fri, 22 Jul 2022 03:10:11 GMT, Leonid Mesnik wrote:
>> So shouldn't we have ZGC test failures then?
>
> No, test passes with ZGC.
I meant shouldn't we see ZGC failures before your changes. Otherwise I don't
understand why this change is needed.
-
PR: https://git.openjdk.org/jdk
On Fri, 22 Jul 2022 00:52:37 GMT, Chris Plummer wrote:
>> Yes, ZGC reports dash for eden and survivor spaces.
>
> So shouldn't we have ZGC test failures then?
No, test passes with ZGC.
-
PR: https://git.openjdk.org/jdk/pull/9604
On Fri, 22 Jul 2022 00:03:26 GMT, Leonid Mesnik wrote:
>> test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48:
>>
>>> 46: S0(GcStatisticsType.PERCENTAGE_OR_DASH),
>>> 47: S1(GcStatisticsType.PERCENTAGE_OR_DASH),
>>> 48: E(GcStatisticsType.PERCENTAGE_OR_DASH),
>>
>>
On Thu, 21 Jul 2022 23:01:55 GMT, Chris Plummer wrote:
>> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
>> output of non-generation (ZGC) GC as valid.
>
> test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48:
>
>> 46: S0(GcStatisticsType.PERCENTAGE_OR_DAS
On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik wrote:
> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
> output of non-generation (ZGC) GC as valid.
test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48:
> 46: S0(GcStatisticsType.PERCENTAGE_OR_DASH),
> 47
Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
output of non-generation (ZGC) GC as valid.
-
Commit messages:
- 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options
Changes: https://git.openjdk.org/jdk/pull/9604/files
Webrev: https://webrevs
10 matches
Mail list logo