Re: RFR: 8295808: GrowableArray should support capacity management [v2]

2022-10-25 Thread Kim Barrett
On Mon, 24 Oct 2022 08:11:42 GMT, Axel Boldt-Christmas wrote: >> Kim Barrett has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >

Re: RFR: 8295808: GrowableArray should support capacity management [v2]

2022-10-25 Thread Kim Barrett
> Please review this change to GrowableArray to support capacity management. > Two functions are added to GrowableArray, reserve and shrink_to_fit. Also > renamed the max_length function to capacity. > > Used these new functions in StringDedupTable. > > Testing: mach5 tier1-3 Kim Barrett has up

Re: RFR: 8295808: GrowableArray should support capacity management

2022-10-25 Thread Kim Barrett
On Mon, 24 Oct 2022 08:11:42 GMT, Axel Boldt-Christmas wrote: > Any thoughts of moving `expand_to` and `shrink_to_fit` to a common function, > given that they share a lot of logic. Something like a general resize that > [...] You are right that there are some opportunities for factoring out c

Re: RFR: 8295808: GrowableArray should support capacity management

2022-10-25 Thread Serguei Spitsyn
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote: > Please review this change to GrowableArray to support capacity management. > Two functions are added to GrowableArray, reserve and shrink_to_fit. Also > renamed the max_length function to capacity. > > Used these new functions in StringDedu

Re: RFR: 8295808: GrowableArray should support capacity management

2022-10-24 Thread Serguei Spitsyn
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote: > Please review this change to GrowableArray to support capacity management. > Two functions are added to GrowableArray, reserve and shrink_to_fit. Also > renamed the max_length function to capacity. > > Used these new functions in StringDedu

Re: RFR: 8295808: GrowableArray should support capacity management

2022-10-24 Thread Thomas Schatzl
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote: > Please review this change to GrowableArray to support capacity management. > Two functions are added to GrowableArray, reserve and shrink_to_fit. Also > renamed the max_length function to capacity. > > Used these new functions in StringDedu

Re: RFR: 8295808: GrowableArray should support capacity management

2022-10-24 Thread Axel Boldt-Christmas
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote: > Please review this change to GrowableArray to support capacity management. > Two functions are added to GrowableArray, reserve and shrink_to_fit. Also > renamed the max_length function to capacity. > > Used these new functions in StringDedu

RFR: 8295808: GrowableArray should support capacity management

2022-10-21 Thread Kim Barrett
Please review this change to GrowableArray to support capacity management. Two functions are added to GrowableArray, reserve and shrink_to_fit. Also renamed the max_length function to capacity. Used these new functions in StringDedupTable. Testing: mach5 tier1-3 - Commit messages: