On Wed, 15 Mar 2023 00:34:00 GMT, Alex Menkov wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClassD
On Wed, 15 Mar 2023 00:34:00 GMT, Alex Menkov wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClassD
On Wed, 15 Mar 2023 00:34:00 GMT, Alex Menkov wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClassD
On Wed, 15 Mar 2023 20:02:11 GMT, Alex Menkov wrote:
> It seems to me that it's much simpler to remove build action from 4 tests in
> the directory than add it for other 55
True. Sadly we keep getting bitten over and over by CODETOOLS-7902847.
Sometimes the "fix" is to remove build directives
On Wed, 15 Mar 2023 18:50:25 GMT, Serguei Spitsyn wrote:
> This looks pretty good. How did you test the fix? Does it never fail with
> your fix? Thanks, Serguei
I run test jobs for "serviceability/sa" 100 times on all platforms, no failures
(neither attach timeout nor NoClassDefFoundError)
--
On Wed, 15 Mar 2023 02:41:18 GMT, David Holmes wrote:
> Not sure removing the build directives was the right way to go. As per the
> jtreg tag guide:
>
> > A test that relies upon library classes should contain appropriate @build
> > directives to ensure that the classes will be compiled. It i
On Wed, 15 Mar 2023 00:34:00 GMT, Alex Menkov wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClassD
On Wed, 15 Mar 2023 00:34:00 GMT, Alex Menkov wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClassD
On Wed, 15 Mar 2023 00:34:32 GMT, Alex Menkov wrote:
>> "else" part is a sub-process.
>> As far as I understand it SATestUtils.skipIfCannotAttach can be skipped for
>> "else", but it's needed for main process.
>
> Added comment.
> Left SATestUtils.skipIfCannotAttach as is (this is consistent wit
On Tue, 14 Mar 2023 23:41:47 GMT, Alex Menkov wrote:
>> test/hotspot/jtreg/serviceability/sa/UniqueVtableTest.java line 195:
>>
>>> 193: } else {
>>> 194: runTest(Long.parseLong(args[0]));
>>> 195: }
>>
>> Could use some comments here. Also, I think `SATestUtils.skip
On Tue, 14 Mar 2023 22:50:32 GMT, Chris Plummer wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback
>
> test/hotspot/jtreg/serviceability/sa/UniqueVtableTest.java line 158:
>
>> 156: Long.toString(
> The change:
> - updates UniqueVtableTest to follow standard SA way - attach to target from
> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
> - updates several tests in the same directory to resolve NoClassDefFoundError
> failures; It's known JTReg issue that "@build"
12 matches
Mail list logo
