Re: RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v6]

2023-06-05 Thread Serguei Spitsyn
On Fri, 2 Jun 2023 19:27:28 GMT, Alex Menkov wrote: >> test/jdk/sun/tools/jcmd/TestJcmdNoAgentLoad.java line 42: >> >>> 40: * @library /test/lib >>> 41: * >>> 42: * @run main/othervm -XX:-EnableDynamicAgentLoading TestJcmdNoAgentLoad >> >> The test verifies only one scenario. I think we

Re: RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v6]

2023-06-02 Thread Alex Menkov
On Fri, 2 Jun 2023 19:23:23 GMT, Alex Menkov wrote: >> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >>

Re: RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v6]

2023-06-02 Thread Alex Menkov
On Fri, 2 Jun 2023 03:44:48 GMT, Serguei Spitsyn wrote: >> The VM option EnableDynamicAgentLoading was added in JDK 9, default true, to >> allow deployment to choose whether to allow agents to be loaded/started in >> the VM. The VM option does the right thing for tools using the Attach API >>

Re: RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v6]

2023-06-01 Thread Chris Plummer
On Fri, 2 Jun 2023 03:44:48 GMT, Serguei Spitsyn wrote: >> The VM option EnableDynamicAgentLoading was added in JDK 9, default true, to >> allow deployment to choose whether to allow agents to be loaded/started in >> the VM. The VM option does the right thing for tools using the Attach API >>

Re: RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v6]

2023-06-01 Thread Serguei Spitsyn
> The VM option EnableDynamicAgentLoading was added in JDK 9, default true, to > allow deployment to choose whether to allow agents to be loaded/started in > the VM. The VM option does the right thing for tools using the Attach API but > jcmd JVMTI.agent_load was missed. This should be fixed to