Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v6]

2023-05-03 Thread Kim Barrett
On Tue, 2 May 2023 16:47:06 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed archive

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v4]

2023-05-03 Thread Kim Barrett
On Thu, 27 Apr 2023 12:31:24 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed archive

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v3]

2023-05-03 Thread Thomas Schatzl
On Wed, 26 Apr 2023 17:28:49 GMT, Chris Plummer wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> cplummer review > > SA changes look good. Thanks @plummercj @sspitsyn @albertnetymk for your reviews -

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v6]

2023-05-02 Thread Albert Mingkun Yang
On Tue, 2 May 2023 16:47:06 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed archive

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v6]

2023-05-02 Thread Serguei Spitsyn
On Tue, 2 May 2023 16:47:06 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed archive

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v5]

2023-05-02 Thread Thomas Schatzl
On Tue, 2 May 2023 15:53:17 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed archive

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v6]

2023-05-02 Thread Thomas Schatzl
> Hi all, > > please review this change that removes the pinned tag from `HeapRegion`. > > So that "pinned" tag for G1 heap regions indicates that the region should not > move during (young) gc. This applies to now removed archive regions and > humongous objects/regions. > > With "real" g1 r

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v5]

2023-05-02 Thread Thomas Schatzl
> Hi all, > > please review this change that removes the pinned tag from `HeapRegion`. > > So that "pinned" tag for G1 heap regions indicates that the region should not > move during (young) gc. This applies to now removed archive regions and > humongous objects/regions. > > With "real" g1 r

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v3]

2023-04-27 Thread Thomas Schatzl
On Thu, 27 Apr 2023 10:38:17 GMT, Albert Mingkun Yang wrote: > > I think you are right about using is_humongous() directly here: the reason > > we skip compacting of humongous regions during the "main" compaction is > > intentional here > > However, I am unable to discern the difference -- why

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v4]

2023-04-27 Thread Thomas Schatzl
> Hi all, > > please review this change that removes the pinned tag from `HeapRegion`. > > So that "pinned" tag for G1 heap regions indicates that the region should not > move during (young) gc. This applies to now removed archive regions and > humongous objects/regions. > > With "real" g1 r

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v3]

2023-04-27 Thread Albert Mingkun Yang
On Wed, 26 Apr 2023 09:12:24 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed archive

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v3]

2023-04-26 Thread Chris Plummer
On Wed, 26 Apr 2023 09:12:24 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed archive

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v3]

2023-04-26 Thread Thomas Schatzl
On Tue, 25 Apr 2023 18:31:19 GMT, Chris Plummer wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> cplummer review > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java line 1109: > >> 1107:

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v3]

2023-04-26 Thread Thomas Schatzl
> Hi all, > > please review this change that removes the pinned tag from `HeapRegion`. > > So that "pinned" tag for G1 heap regions indicates that the region should not > move during (young) gc. This applies to now removed archive regions and > humongous objects/regions. > > With "real" g1 r

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v2]

2023-04-25 Thread Chris Plummer
On Tue, 25 Apr 2023 15:59:05 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed archive

Re: RFR: 8306836: Remove pinned tag for G1 heap regions [v2]

2023-04-25 Thread Thomas Schatzl
> Hi all, > > please review this change that removes the pinned tag from `HeapRegion`. > > So that "pinned" tag for G1 heap regions indicates that the region should not > move during (young) gc. This applies to now removed archive regions and > humongous objects/regions. > > With "real" g1 r

Re: RFR: 8306836: Remove pinned tag for G1 heap regions

2023-04-25 Thread Thomas Schatzl
On Tue, 25 Apr 2023 15:29:08 GMT, Thomas Schatzl wrote: >> src/hotspot/share/gc/g1/g1HeapVerifier.cpp line 414: >> >>> 412: // There are no other valid region types. Check for one invalid >>> 413: // one we can identify before crashing: non-movable. >>> 414: assert(hr->is_young

Re: RFR: 8306836: Remove pinned tag for G1 heap regions

2023-04-25 Thread Thomas Schatzl
On Tue, 25 Apr 2023 15:05:10 GMT, Albert Mingkun Yang wrote: >> Hi all, >> >> please review this change that removes the pinned tag from `HeapRegion`. >> >> So that "pinned" tag for G1 heap regions indicates that the region should >> not move during (young) gc. This applies to now removed ar

Re: RFR: 8306836: Remove pinned tag for G1 heap regions

2023-04-25 Thread Albert Mingkun Yang
On Tue, 25 Apr 2023 13:49:05 GMT, Thomas Schatzl wrote: > Hi all, > > please review this change that removes the pinned tag from `HeapRegion`. > > So that "pinned" tag for G1 heap regions indicates that the region should not > move during (young) gc. This applies to now removed archive regio

RFR: 8306836: Remove pinned tag for G1 heap regions

2023-04-25 Thread Thomas Schatzl
Hi all, please review this change that removes the pinned tag from `HeapRegion`. So that "pinned" tag for G1 heap regions indicates that the region should not move during (young) gc. This applies to now removed archive regions and humongous objects/regions. With "real" g1 region pinning to d