> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains four add
On Thu, 11 May 2023 04:08:37 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains four
>> additional
On Wed, 10 May 2023 19:56:53 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
>
> Daniel D. Daugherty has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated chang
> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three ad
On Thu, 4 May 2023 05:11:53 GMT, Robbin Ehn wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes CR - change ':' to '.'.
>
> Looks good, thanks!
@robehn - Thanks for the re-review!
-
PR Com
On Tue, 2 May 2023 20:37:18 GMT, Daniel D. Daugherty wrote:
>> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
>
> Daniel D. Daugherty has updated the pull request incrementally with one
> additional commit since the last revision:
>
> dholmes CR - change ':' to '.'.
On Tue, 2 May 2023 20:37:18 GMT, Daniel D. Daugherty wrote:
>> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
>
> Daniel D. Daugherty has updated the pull request incrementally with one
> additional commit since the last revision:
>
> dholmes CR - change ':' to '.'.
On Tue, 2 May 2023 08:04:52 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes CR - change ':' to '.'.
>
> src/hotspot/share/runtime/threadSMR.cpp line 828:
>
>> 826: if (java_threa
On Mon, 1 May 2023 13:44:22 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes CR - change ':' to '.'.
>
> Yes, this looks good and also trivial.
@coleenp, @dholmes-ora and @sspi
> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
Daniel D. Daugherty has updated the pull request incrementally with one
additional commit since the last revision:
dholmes CR - change ':' to '.'.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1370
On Thu, 27 Apr 2023 22:17:30 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
Marked as reviewed by sspitsyn (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13704#pullrequestreview-1408752268
On Thu, 27 Apr 2023 22:17:30 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
One minor nit but otherwise good. Thanks.
src/hotspot/share/runtime/threadSMR.cpp line 828:
> 826: if (java_thread != JavaThread::current()) {
> 827:
On Thu, 27 Apr 2023 22:17:30 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
Yes, this looks good and also trivial.
-
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13704#pullreques
A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
-
Commit messages:
- 8307067: remove broken EnableThreadSMRExtraValidityChecks option
Changes: https://git.openjdk.org/jdk/pull/13704/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13704&range=00
Is
14 matches
Mail list logo
