Re: RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v2]

2023-06-27 Thread Coleen Phillimore
On Tue, 27 Jun 2023 14:54:03 GMT, Coleen Phillimore wrote: >> src/hotspot/share/code/codeBlob.inline.hpp line 36: >> >>> 34: inline const ImmutableOopMap* CodeBlob::oop_map_for_slot(int slot, >>> address return_address) const { >>> 35: assert(_oop_maps != nullptr, "nope"); >>> 36: return

Re: RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v2]

2023-06-27 Thread Coleen Phillimore
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but > I've added a pointer delta function in globalDefinitions.hpp to use for these > pointer diff calculations that return int everywhere. If the name is > agreeable, I'll fix the other cases of this like this. It's