On Wed, 12 Jul 2023 23:21:12 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More review comments
>>
>> Signed-off-by: Ashutosh Mehra
>
> Marked as reviewed by cjplummer (Reviewer).
@plu
On Wed, 12 Jul 2023 18:48:42 GMT, Ashutosh Mehra wrote:
>> Please review this PR that enables ClassWriter to write annotations to the
>> class file being dumped.
>>
>> The fields annotations are stored in `Annotations::_fields_annotations`
>> which is of type `Array*>`. There is no class in SA
On Wed, 12 Jul 2023 15:17:10 GMT, Thomas Stuefe wrote:
>>> What would be needed to make the Annotations appear in the "printall"
>>> command? I was somehow expecting to see at least something like
>>> "Annotation@".
>>
>> I am not sure what all details `printall` is expected to emit out. L
On Wed, 12 Jul 2023 18:48:42 GMT, Ashutosh Mehra wrote:
>> Please review this PR that enables ClassWriter to write annotations to the
>> class file being dumped.
>>
>> The fields annotations are stored in `Annotations::_fields_annotations`
>> which is of type `Array*>`. There is no class in SA
On Tue, 11 Jul 2023 20:28:29 GMT, Chris Plummer wrote:
>> I think VMObjectFactory is a better place to implement the caching behavior
>> so that all such patterns can benefit from it. I think it is better
>> addressed in another task.
>
> I think maybe you misunderstood what I meant by "cache".
> Please review this PR that enables ClassWriter to write annotations to the
> class file being dumped.
>
> The fields annotations are stored in `Annotations::_fields_annotations` which
> is of type `Array*>`. There is no class in SA that can represent
> it. I have added ArrayOfU1Array to corre
