Re: RFR: 8311879: ClassWriter generates invalid invokedynamic code [v2]

2023-07-13 Thread Chris Plummer
On Thu, 13 Jul 2023 03:25:38 GMT, Daohan Qu wrote: >> This patch should fix the wrong CP index for `invokedynamic` instruction >> generated by SA's `ClassWriter`. The buggy code in >> `sun.jvm.hotspot.tools.jcore.ByteCodeRewriter` should have been up-to-date >> with the following code snippet

Re: RFR: 8311879: ClassWriter generates invalid invokedynamic code [v2]

2023-07-13 Thread Matias Saavedra Silva
On Thu, 13 Jul 2023 03:25:38 GMT, Daohan Qu wrote: >> This patch should fix the wrong CP index for `invokedynamic` instruction >> generated by SA's `ClassWriter`. The buggy code in >> `sun.jvm.hotspot.tools.jcore.ByteCodeRewriter` should have been up-to-date >> with the following code snippet

Re: RFR: 8311879: ClassWriter generates invalid invokedynamic code [v2]

2023-07-12 Thread Daohan Qu
On Wed, 12 Jul 2023 15:20:35 GMT, Chen Liang wrote: >> Daohan Qu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use Assert instead of throwing exceptions > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewrit

Re: RFR: 8311879: ClassWriter generates invalid invokedynamic code [v2]

2023-07-12 Thread Daohan Qu
> This patch should fix the wrong CP index for `invokedynamic` instruction > generated by SA's `ClassWriter`. The buggy code in > `sun.jvm.hotspot.tools.jcore.ByteCodeRewriter` should have been up-to-date > with the following code snippet in `hotspot`: > > https://github.com/openjdk/jdk/blob/75

Re: RFR: 8311879: ClassWriter generates invalid invokedynamic code

2023-07-12 Thread Chen Liang
On Wed, 12 Jul 2023 13:49:17 GMT, Daohan Qu wrote: > This patch should fix the wrong CP index for `invokedynamic` instruction > generated by SA's `ClassWriter`. The buggy code in > `sun.jvm.hotspot.tools.jcore.ByteCodeRewriter` should have been up-to-date > with the following code snippet in `

RFR: 8311879: ClassWriter generates invalid invokedynamic code

2023-07-12 Thread Daohan Qu
This patch should fix the wrong CP index for `invokedynamic` instruction generated by SA's `ClassWriter`. The buggy code in `sun.jvm.hotspot.tools.jcore.ByteCodeRewriter` should have been up-to-date with the following code snippet in `hotspot`: https://github.com/openjdk/jdk/blob/753bd563ecca6b