Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code [v2]

2023-09-12 Thread Jiangli Zhou
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou wrote: >> Please review this simple change from @cjmoon1 for resolving static linking >> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be >> found at: >> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_no

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code [v2]

2023-09-11 Thread David Holmes
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou wrote: >> Please review this simple change from @cjmoon1 for resolving static linking >> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be >> found at: >> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_no

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code [v2]

2023-09-02 Thread Serguei Spitsyn
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou wrote: >> Please review this simple change from @cjmoon1 for resolving static linking >> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be >> found at: >> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_no

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code [v2]

2023-09-02 Thread Thomas Stuefe
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou wrote: >> Please review this simple change from @cjmoon1 for resolving static linking >> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be >> found at: >> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_no

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code [v2]

2023-09-01 Thread Jiangli Zhou
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou wrote: >> Please review this simple change from @cjmoon1 for resolving static linking >> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be >> found at: >> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_no

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code [v2]

2023-09-01 Thread Jiangli Zhou
> Please review this simple change from @cjmoon1 for resolving static linking > issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be > found at: > https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_normalize. > > The change incorporated suggestions from both