Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-20 Thread Daniel D . Daugherty
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. Thumbs up. Please

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-20 Thread Kevin Walls
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. Marked as reviewed by

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread Leonid Mesnik
On Wed, 20 Sep 2023 05:32:07 GMT, David Holmes wrote: >> Test start failing because of unexpected VM logging. >> The fix is to search expected string ignoring any unknown output from forked >> process. >> Tested with tier1 and by running test with various options used in CI. > >

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread David Holmes
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. Okay - seems

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread David Holmes
On Wed, 20 Sep 2023 05:23:12 GMT, Leonid Mesnik wrote: > OutputAnalyzer 'firstmatch' method analyze result. It analyze string from > 'String OutputBuffer getStdout()' and can't be used to communicate with > process. Ah I see. > Something like this was my first fix. Use

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread Leonid Mesnik
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. OutputAnalyzer

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread Leonid Mesnik
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. Something like this

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread David Holmes
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. Or even use the

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread David Holmes
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. Can't you just change

RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread Leonid Mesnik
Test start failing because of unexpected VM logging. The fix is to search expected string ignoring any unknown output from forked process. Tested with tier1 and by running test with various options used in CI. - Commit messages: - 8316562: