Re: RFR: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception

2024-01-05 Thread Chris Plummer
On Thu, 4 Jan 2024 02:00:24 GMT, Chris Plummer wrote: > Use "cause" argument when rethrowing an exception. See CR for details on how > this helps. > > Tested with all of tier1, and also ran tier2 and tier4 svc tests. > > I'd like to push this as a trivial change. Thanks for the reviews David

Re: RFR: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception

2024-01-04 Thread Leonid Mesnik
On Thu, 4 Jan 2024 02:00:24 GMT, Chris Plummer wrote: > Use "cause" argument when rethrowing an exception. See CR for details on how > this helps. > > Tested with all of tier1, and also ran tier2 and tier4 svc tests. > > I'd like to push this as a trivial change. Marked as reviewed by lmesnik

Re: RFR: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception

2024-01-04 Thread David Holmes
On Thu, 4 Jan 2024 02:00:24 GMT, Chris Plummer wrote: > Use "cause" argument when rethrowing an exception. See CR for details on how > this helps. > > Tested with all of tier1, and also ran tier2 and tier4 svc tests. > > I'd like to push this as a trivial change. Okay - thanks. Change is triv

Re: RFR: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception

2024-01-04 Thread Chris Plummer
On Thu, 4 Jan 2024 06:56:37 GMT, David Holmes wrote: > Setting the cause is good, but do you not also want an informative message? Not necessary. public class Test { public static void main(String[] args) { try { try { throw new Throwable("hello");

Re: RFR: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception

2024-01-03 Thread David Holmes
On Thu, 4 Jan 2024 02:00:24 GMT, Chris Plummer wrote: > Use "cause" argument when rethrowing an exception. See CR for details on how > this helps. > > Tested with all of tier1, and also ran tier2 and tier4 svc tests. > > I'd like to push this as a trivial change. Setting the cause is good, bu

RFR: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception

2024-01-03 Thread Chris Plummer
Use "cause" argument when rethrowing an exception. See CR for details on how this helps. Tested with all of tier1, and also ran tier2 and tier4 svc tests. I'd like to push this as a trivial change. - Commit messages: - Use "cause" argument when rethrowing an exception Changes: ht