On Thu, 4 Jan 2024 15:54:50 GMT, Stefan Karlsson wrote:
> It means that either Serial is set (and available) or it can be set
@stefank that is subtle - and unintuitive. Thanks for explaining.
-
PR Comment: https://git.openjdk.org/jdk/pull/17263#issuecomment-1877728970
On Thu, 4 Jan 2024 15:37:33 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit
On Thu, 4 Jan 2024 16:06:26 GMT, Daniel D. Daugherty wrote:
> We're up to 48 test failures so far (8 x 6 Tier3 buildIDs) which is very,
> very noisy. Since it looks like this PR is still being discussed, I'm going
> to ProblemList this test in order to get the noise level back down.
sorry for
On Thu, 4 Jan 2024 15:37:33 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit
On Thu, 4 Jan 2024 11:56:45 GMT, David Holmes wrote:
> > For this test I think we can just add @requires vm.gc.Serial
>
> @stefank but it doesn't require that, it explicitly sets that. The test
> requires that no specific GC has been requested.
@dholmes-ora `@requires vm.gc.Serial` doesn't
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
-
