> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request incrementally with one additional
commit since the last revision:
update copyright
-
Change
On Thu, 4 Jan 2024 20:37:39 GMT, David Holmes wrote:
>>> > For this test I think we can just add @requires vm.gc.Serial
>>>
>>> @stefank but it doesn't require that, it explicitly sets that. The test
>>> requires that no specific GC has been requested.
>>
>> @dholmes-ora `@requires vm.gc.Seria
On Fri, 5 Jan 2024 02:24:44 GMT, Denghui Dong wrote:
>>> It means that either Serial is set (and available) or it can be set
>>
>> @stefank that is subtle - and unintuitive. Thanks for explaining.
>
> @dholmes-ora Thanks for the review.
>
> This change only involves the test part. Do I need a
On Fri, 5 Jan 2024 02:22:45 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit s
On Fri, 5 Jan 2024 02:22:45 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit s
