Re: RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB [v2]

2024-02-02 Thread Chris Plummer
On Fri, 26 Jan 2024 21:20:04 GMT, Chris Plummer wrote: >> In PointerFinder.java we have some code to determine if a pointer is in a >> TLAB, but it only executes for the SerialGC. It should work for all GCs, so >> I moved the code out of the SerialGC block. >> >> I also cleaned up the

Re: RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB [v2]

2024-02-02 Thread Serguei Spitsyn
On Fri, 26 Jan 2024 21:20:04 GMT, Chris Plummer wrote: >> In PointerFinder.java we have some code to determine if a pointer is in a >> TLAB, but it only executes for the SerialGC. It should work for all GCs, so >> I moved the code out of the SerialGC block. >> >> I also cleaned up the

Re: RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB [v2]

2024-01-30 Thread Chris Plummer
On Fri, 26 Jan 2024 21:20:04 GMT, Chris Plummer wrote: >> In PointerFinder.java we have some code to determine if a pointer is in a >> TLAB, but it only executes for the SerialGC. It should work for all GCs, so >> I moved the code out of the SerialGC block. >> >> I also cleaned up the

Re: RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB [v2]

2024-01-26 Thread Chris Plummer
On Fri, 26 Jan 2024 17:05:51 GMT, Kevin Walls wrote: > (Not critical, but maybe PointerLocation doesn't need the boolean inTlab. It > could use that its tlab is not null, like the isInHeap/stack/metadata checks > that something is not null.) Ok. I made that change. - PR Comment:

Re: RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB [v2]

2024-01-26 Thread Chris Plummer
> In PointerFinder.java we have some code to determine if a pointer is in a > TLAB, but it only executes for the SerialGC. It should work for all GCs, so I > moved the code out of the SerialGC block. > > I also cleaned up the printing in PointerLocation. java a bit so when not > using verbose

Re: RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB

2024-01-26 Thread Kevin Walls
On Thu, 18 Jan 2024 22:54:26 GMT, Chris Plummer wrote: > In PointerFinder.java we have some code to determine if a pointer is in a > TLAB, but it only executes for the SerialGC. It should work for all GCs, so I > moved the code out of the SerialGC block. > > I also cleaned up the printing in

Re: RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB

2024-01-22 Thread Chris Plummer
On Thu, 18 Jan 2024 22:54:26 GMT, Chris Plummer wrote: > In PointerFinder.java we have some code to determine if a pointer is in a > TLAB, but it only executes for the SerialGC. It should work for all GCs, so I > moved the code out of the SerialGC block. > > I also cleaned up the printing in

RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB

2024-01-18 Thread Chris Plummer
In PointerFinder.java we have some code to determine if a pointer is in a TLAB, but it only executes for the SerialGC. It should work for all GCs, so I moved the code out of the SerialGC block. I also cleaned up the printing in PointerLocation. java a bit so when not using verbose mode not as