Re: RFR: 8324512: Serial: Remove Generation::Name [v2]

2024-01-24 Thread Albert Mingkun Yang
On Tue, 23 Jan 2024 18:37:45 GMT, Albert Mingkun Yang wrote: >> Trivial removing redundant code. > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > year Thanks for review. - PR Comment:

Re: RFR: 8324512: Serial: Remove Generation::Name [v2]

2024-01-23 Thread Albert Mingkun Yang
> Trivial removing redundant code. Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision: year - Changes: - all: https://git.openjdk.org/jdk/pull/17530/files - new:

Re: RFR: 8324512: Serial: Remove Generation::Name

2024-01-23 Thread Chris Plummer
On Tue, 23 Jan 2024 10:20:46 GMT, Albert Mingkun Yang wrote: > Trivial removing redundant code. SA changes look good to me. Copyrights still need updating in a few files. - Marked as reviewed by cjplummer (Reviewer). PR Review:

Re: RFR: 8324512: Serial: Remove Generation::Name

2024-01-23 Thread Ivan Walulya
On Tue, 23 Jan 2024 10:20:46 GMT, Albert Mingkun Yang wrote: > Trivial removing redundant code. Marked as reviewed by iwalulya (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17530#pullrequestreview-1839014944

Re: RFR: 8324512: Serial: Remove Generation::Name

2024-01-23 Thread Stefan Karlsson
On Tue, 23 Jan 2024 10:20:46 GMT, Albert Mingkun Yang wrote: > Trivial removing redundant code. Marked as reviewed by stefank (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17530#pullrequestreview-1838769192

RFR: 8324512: Serial: Remove Generation::Name

2024-01-23 Thread Albert Mingkun Yang
Trivial removing redundant code. - Commit messages: - s1-enum Changes: https://git.openjdk.org/jdk/pull/17530/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17530=00 Issue: https://bugs.openjdk.org/browse/JDK-8324512 Stats: 66 lines in 9 files changed: 0 ins; 64 del; 2