Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v2]

2024-05-09 Thread Matias Saavedra Silva
On Tue, 7 May 2024 21:39:04 GMT, Chris Plummer wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Chris comments and cleanup > > SA changes look good. Thanks for taking care of this. Thanks for the reviews @

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v4]

2024-05-09 Thread Matias Saavedra Silva
> The beginning of the RW region contains pointers to c++ vtables which are > always located at a fixed offset from the shared base address at runtime. > This offset can be calculated at dumptime and stored with the read-only > tables at the top of the RO region. As a further improvement, all th

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v3]

2024-05-09 Thread Ioi Lam
On Thu, 9 May 2024 18:31:24 GMT, Matias Saavedra Silva wrote: >> The beginning of the RW region contains pointers to c++ vtables which are >> always located at a fixed offset from the shared base address at runtime. >> This offset can be calculated at dumptime and stored with the read-only >>

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v3]

2024-05-09 Thread Matias Saavedra Silva
> The beginning of the RW region contains pointers to c++ vtables which are > always located at a fixed offset from the shared base address at runtime. > This offset can be calculated at dumptime and stored with the read-only > tables at the top of the RO region. As a further improvement, all th

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v2]

2024-05-08 Thread Ioi Lam
On Tue, 7 May 2024 16:38:23 GMT, Matias Saavedra Silva wrote: >> The beginning of the RW region contains pointers to c++ vtables which are >> always located at a fixed offset from the shared base address at runtime. >> This offset can be calculated at dumptime and stored with the read-only >>

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v2]

2024-05-07 Thread Chris Plummer
On Tue, 7 May 2024 16:38:23 GMT, Matias Saavedra Silva wrote: >> The beginning of the RW region contains pointers to c++ vtables which are >> always located at a fixed offset from the shared base address at runtime. >> This offset can be calculated at dumptime and stored with the read-only >>

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v2]

2024-05-07 Thread Matias Saavedra Silva
> The beginning of the RW region contains pointers to c++ vtables which are > always located at a fixed offset from the shared base address at runtime. > This offset can be calculated at dumptime and stored with the read-only > tables at the top of the RO region. As a further improvement, all th

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap

2024-05-07 Thread Matias Saavedra Silva
On Mon, 6 May 2024 22:32:12 GMT, Chris Plummer wrote: >> The beginning of the RW region contains pointers to c++ vtables which are >> always located at a fixed offset from the shared base address at runtime. >> This offset can be calculated at dumptime and stored with the read-only >> tables a

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap

2024-05-06 Thread Chris Plummer
On Mon, 6 May 2024 17:05:47 GMT, Matias Saavedra Silva wrote: > The beginning of the RW region contains pointers to c++ vtables which are > always located at a fixed offset from the shared base address at runtime. > This offset can be calculated at dumptime and stored with the read-only > tab

RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap

2024-05-06 Thread Matias Saavedra Silva
The beginning of the RW region contains pointers to c++ vtables which are always located at a fixed offset from the shared base address at runtime. This offset can be calculated at dumptime and stored with the read-only tables at the top of the RO region. As a further improvement, all the pointe