Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v4]

2024-06-03 Thread Inigo Mediavilla Saiz
On Mon, 3 Jun 2024 08:34:11 GMT, David Holmes wrote: >> I also find the duplication of the stack printing code unfortunate. It would >> be nice to reuse`JavaThread::print_vthread_stack_on`. I don't understand why >> it cannot be const? > >> I also find the duplication of the stack printing

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v4]

2024-06-03 Thread Inigo Mediavilla Saiz
On Mon, 3 Jun 2024 09:01:52 GMT, Andrey Turbanov wrote: >> Inigo Mediavilla Saiz has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add missing header > > test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java > line

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v4]

2024-06-03 Thread Andrey Turbanov
On Mon, 3 Jun 2024 08:30:15 GMT, Inigo Mediavilla Saiz wrote: >> Print the stack traces of mounted virtual threads when calling `jcmd >> Thread.print`. > > Inigo Mediavilla Saiz has updated the pull request incrementally with one > additional commit since the last revision: > > Add missing

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v4]

2024-06-03 Thread David Holmes
On Mon, 3 Jun 2024 08:31:46 GMT, Thomas Stuefe wrote: > I also find the duplication of the stack printing code unfortunate. It would > be nice to reuse`JavaThread::print_vthread_stack_on`. I don't understand why > it cannot be const? Just what I was about to query :) I'm not sure what the

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v4]

2024-06-03 Thread Thomas Stuefe
On Mon, 3 Jun 2024 08:30:15 GMT, Inigo Mediavilla Saiz wrote: >> Print the stack traces of mounted virtual threads when calling `jcmd >> Thread.print`. > > Inigo Mediavilla Saiz has updated the pull request incrementally with one > additional commit since the last revision: > > Add missing

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v4]

2024-06-03 Thread Inigo Mediavilla Saiz
> Print the stack traces of mounted virtual threads when calling `jcmd > Thread.print`. Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision: Add missing header - Changes: - all: