Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Sonia Zaldana Calles
> Hi all, > > This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) > enabling jcmd to accept "help" as an argument to subcommands. > > Testing: > - [x] Verified running `jcmd 4711 VM.metaspace help` works along with other > subcommands. > - [x] Added test case passes. >

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Kevin Walls
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help` wo

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Laurence Cable
what about '*jcmd help *' not a great deal of additional code for the 'help' jcmd to delegate to the target jcmd? - Larry On 6/25/24 10:15 AM, Kevin Walls wrote: On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: Hi all, This PR addresses [8332124](https://bugs.openjdk.org/b

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Laurence Cable
and jcmd already supports "help" w/o a target argument, so this pattern is a natural extension, and one which other toolsets have adopted! On 6/25/24 1:28 PM, Laurence Cable wrote: what about '*jcmd help *' not a great deal of additional code for the 'help' jcmd to delegate to the target jcm

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Thomas Stuefe
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help` wo

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-26 Thread Kevin Walls
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help` wo

Fwd: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-26 Thread Laurence Cable
Forwarded Message Subject: Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2] Date: Tue, 25 Jun 2024 13:30:04 -0700 From: Laurence Cable To: serviceability-dev@openjdk.org what about '*jcmd help *&#x

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-26 Thread Sonia Zaldana Calles
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help` wo

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-27 Thread Kevin Walls
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help` wo