On Fri, 24 May 2024 18:22:18 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Fri, 24 May 2024 18:22:18 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Fri, 24 May 2024 18:04:20 GMT, Chris Plummer wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove should... from delegationSubjects param
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RM
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
> a
On Fri, 24 May 2024 17:15:31 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
> a
On Fri, 24 May 2024 16:49:25 GMT, Chris Plummer wrote:
>> Thanks, appreciate the effort trying to make it perfect.
>> Can't quite say "must be null or an array of all null entries" ..because I
>> suppose it could be an empty array.
>>
>> In reality, the only caller is our code that wraps a nu
On Fri, 24 May 2024 16:43:41 GMT, Kevin Walls wrote:
>> How about "must be null or an array of all null entries". You could still
>> have an `@apiNote` explaining why.
>
> Thanks, appreciate the effort trying to make it perfect.
> Can't quite say "must be null or an array of all null entries"
On Fri, 24 May 2024 15:50:00 GMT, Chris Plummer wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java
>> line 961:
>>
>>> 959: * @param delegationSubjects should be {@code null}, but a non-null
>>> 960: * array is also accepted for compatibilit
On Fri, 17 May 2024 10:35:39 GMT, Alan Bateman wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add an 'also'
>> - typo
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java
> l
On Thu, 16 May 2024 08:25:17 GMT, Kevin Walls wrote:
>>> > ...Is there any way to run jconsole in a way that would result in it
>>> > passing a non-empty delegationSubjects, resulting in this issue still
>>> > reproducing?
>>>
>>> I don't think there is, JConsole has a hard null in this call.
On Thu, 16 May 2024 08:25:17 GMT, Kevin Walls wrote:
>>> > ...Is there any way to run jconsole in a way that would result in it
>>> > passing a non-empty delegationSubjects, resulting in this issue still
>>> > reproducing?
>>>
>>> I don't think there is, JConsole has a hard null in this call.
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
> a
On Fri, 17 May 2024 10:14:43 GMT, Daniel Fuchs wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add an 'also'
>> - typo
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java
> l
On Thu, 16 May 2024 20:17:18 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Thu, 16 May 2024 20:17:18 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Thu, 16 May 2024 19:53:48 GMT, Sean Mullan wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> IllegalArgumentException throws doc update
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConne
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
> a
On Thu, 16 May 2024 11:46:30 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Thu, 16 May 2024 11:38:28 GMT, Daniel Fuchs wrote:
>> Yes, completely understand. I just don't think it has any benefit.
>
> Hmmm... the spec still says:
>
> * @throws IllegalArgumentException if names or
> * filters is null, or if names contains
> * a null element, or if the
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
> a
On Thu, 16 May 2024 10:37:36 GMT, Kevin Walls wrote:
>> This shows that when SubjectDelegation was not used, a null-filled array of
>> the same length as the two other arrays was expected before (in previous
>> versions of the JDK where SubjectDelegation was supported, but in the case
>> where
On Thu, 16 May 2024 10:26:25 GMT, Daniel Fuchs wrote:
>> That the JConsole tab was blank shows that the older RMIConnector's
>> addListenerWithSubject creates a new single-entry array from the given
>> delegationSubject (which is null) and passes it onwards. The app is not
>> creating the arr
On Thu, 16 May 2024 10:16:58 GMT, Kevin Walls wrote:
>> Well my thinking was this: the fact that the jconsole tab was blank shows
>> that the array may being passed. The previous code verified that all three
>> arrays had the same length - so it would have failed if the array had a
>> length d
On Thu, 16 May 2024 09:40:58 GMT, Daniel Fuchs wrote:
>> That seems pretty extreme -- it's an array we explicitly don't want and are
>> going to ignore? If somebody passes a non-null member, we will throw as
>> unsupported. I was thinking that was enough, hence removing the sbjs array
>> to
On Wed, 15 May 2024 20:02:26 GMT, Kevin Walls wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
>> line 984:
>>
>>> 982: }
>>> 983: if (names.length != filters.length) {
>>> 984: final String msg = "The lengths of name
On Wed, 15 May 2024 22:44:03 GMT, Serguei Spitsyn wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
On Wed, 15 May 2024 23:40:00 GMT, Chris Plummer wrote:
> If jconsole is passing null, why is it triggering this exception?
JConsole passes null, but when running on an older jdk, the older RMIConnector
actually "promotes" it to an array before making the remote call. If you
connect to a jdk-2
On Wed, 15 May 2024 21:38:54 GMT, Kevin Walls wrote:
> > ...Is there any way to run jconsole in a way that would result in it
> > passing a non-empty delegationSubjects, resulting in this issue still
> > reproducing?
>
> I don't think there is, JConsole has a hard null in this call. Also I don
On Wed, 15 May 2024 16:59:59 GMT, Kevin Walls wrote:
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In
On Wed, 15 May 2024 21:20:25 GMT, Chris Plummer wrote:
> ...Is there any way to run jconsole in a way that would result in it passing
> a non-empty delegationSubjects, resulting in this issue still reproducing?
I don't think there is, JConsole has a hard null in this call. Also I don't
see in
On Wed, 15 May 2024 16:59:59 GMT, Kevin Walls wrote:
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In
On Wed, 15 May 2024 19:09:54 GMT, Chris Plummer wrote:
> I'm just trying to understand current and previous behavior of jconsole a bit
> better.
Right, to be clear it's not JConsole's fault. The early part of JConsole's
stack is:
...connection
at
java.management.rmi/javax.
On Wed, 15 May 2024 17:49:07 GMT, Daniel Fuchs wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Wed, 15 May 2024 16:59:59 GMT, Kevin Walls wrote:
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In
On Wed, 15 May 2024 16:59:59 GMT, Kevin Walls wrote:
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In
Running JConsole from a previous JDK, and attaching to jdk-23 (after
[JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
Management Extension (JMX) Subject Delegation feature), the MBean tab is blank.
In javax/management/remote/rmi/RMIConnectionImpl.java:
addNotificationL
37 matches
Mail list logo
