Re: RFR: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization

2024-05-30 Thread Serguei Spitsyn
On Tue, 28 May 2024 20:24:31 GMT, Leonid Mesnik wrote: > The > test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java > uses cleanup() to kill debuggee process. > > However, most tests kill the debuggee process explicitly. I verified that > debuggee process is killed before test fini

Re: RFR: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization

2024-05-29 Thread Chris Plummer
On Tue, 28 May 2024 20:24:31 GMT, Leonid Mesnik wrote: > The > test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java > uses cleanup() to kill debuggee process. > > However, most tests kill the debuggee process explicitly. I verified that > debuggee process is killed before test fini

Re: RFR: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization

2024-05-29 Thread Leonid Mesnik
On Tue, 28 May 2024 22:51:36 GMT, Chris Plummer wrote: >> The >> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java >> uses cleanup() to kill debuggee process. >> >> However, most tests kill the debuggee process explicitly. I verified that >> debuggee process is killed before tes

Re: RFR: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization

2024-05-28 Thread Chris Plummer
On Tue, 28 May 2024 20:24:31 GMT, Leonid Mesnik wrote: > I verified that debuggee process is killed before test finishes. (Just by > printing it's status.) What about when the test fails? test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/exit/exit001.java line 177: > 175: > 176: i

RFR: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization

2024-05-28 Thread Leonid Mesnik
The test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java uses cleanup() to kill debuggee process. However, most tests kill the debuggee process explicitly. I verified that debuggee process is killed before test finishes. (Just by printing it's status.) The fix adds a few checks debu