Re: RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic [v2]

2024-06-10 Thread Jaikiran Pai
On Tue, 11 Jun 2024 02:10:46 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test-only change which fixes an issue that >> was introduced due to the refactoring that we did in >> https://bugs.openjdk.org/browse/JDK-8333130? This PR addresses the failure >> reported in https://bug

Re: RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic [v2]

2024-06-10 Thread Chris Plummer
On Tue, 11 Jun 2024 02:10:46 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test-only change which fixes an issue that >> was introduced due to the refactoring that we did in >> https://bugs.openjdk.org/browse/JDK-8333130? This PR addresses the failure >> reported in https://bug

Re: RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic [v2]

2024-06-10 Thread Jaikiran Pai
On Mon, 10 Jun 2024 19:05:36 GMT, Chris Plummer wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update code comment > > test/jdk/java/lang/instrument/NativeMethodPrefixApp.java line 103: > >> 101:

Re: RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic [v2]

2024-06-10 Thread Jaikiran Pai
> Can I please get a review of this test-only change which fixes an issue that > was introduced due to the refactoring that we did in > https://bugs.openjdk.org/browse/JDK-8333130? This PR addresses the failure > reported in https://bugs.openjdk.org/browse/JDK-8333756. > > The `NativeMethodPref

Re: RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic

2024-06-10 Thread Chris Plummer
On Fri, 7 Jun 2024 10:31:22 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which fixes an issue that > was introduced due to the refactoring that we did in > https://bugs.openjdk.org/browse/JDK-8333130? This PR addresses the failure > reported in https://bugs.ope

Re: RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic

2024-06-09 Thread Jaikiran Pai
On Fri, 7 Jun 2024 10:31:22 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which fixes an issue that > was introduced due to the refactoring that we did in > https://bugs.openjdk.org/browse/JDK-8333130? This PR addresses the failure > reported in https://bugs.ope

Re: RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic

2024-06-07 Thread Jaikiran Pai
On Fri, 7 Jun 2024 10:31:22 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which fixes an issue that > was introduced due to the refactoring that we did in > https://bugs.openjdk.org/browse/JDK-8333130? This PR addresses the failure > reported in https://bugs.ope

Re: RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic

2024-06-07 Thread Alex Menkov
On Fri, 7 Jun 2024 10:31:22 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which fixes an issue that > was introduced due to the refactoring that we did in > https://bugs.openjdk.org/browse/JDK-8333130? This PR addresses the failure > reported in https://bugs.ope

RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic

2024-06-07 Thread Jaikiran Pai
Can I please get a review of this test-only change which fixes an issue that was introduced due to the refactoring that we did in https://bugs.openjdk.org/browse/JDK-8333130? This PR addresses the failure reported in https://bugs.openjdk.org/browse/JDK-8333756. The `NativeMethodPrefixApp` test